chore(package): typescript 6 as peer optional - #460
Open
furcan wants to merge 1 commit into
Open
Conversation
|
Would love to see this merged. |
|
Hello! Could this PR be merged? |
Author
|
I tried to contact with the owner of this project, but couldn't get any answer yet (I hope they are doing well) So, for PNPM, it handles this with graceful warnings, but for NPM, it will block the processes, And due to unblocking your CI/CD, for What is Mitigation: "overrides": {
"madge": {
"typescript": "$typescript",
"precinct": {
"detective-typescript": {
"typescript": "$typescript"
},
"detective-vue2": {
"typescript": "$typescript"
}
}
}
} |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
First of all, great tool, thank you very much for this library.
Continuing, with the TypeScript 6 projects,
PNPM does handle this with graceful warnings but native NPM is complaining.
Note
I am also not sure why TypeScript is a peer dependency for this package, do we really need this?Overall, this a JavaScript library and I did not see a use in lib code as TS, its JS.But, if I am missing something, please update the PR.Yes, I was missing something, its in use as an api for reading the optional
tsConfigprop formadgeto read/merge the given tsconfig.json forpathanalysis/resolution.And this is opening another door that, "typescript is a direct dependency" for this library by the package management aspect. The optional use case in the code itself does not make a package as peer optional.
Overall, adding TypeScript 6 as peer due to current package.json/project structure still valid, and the following comment can mitigate the issue.
Changes