Skip to content

Some more cleanups #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsparber merged 3 commits into from
Apr 11, 2026
Merged

Some more cleanups #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f83f49
Remove default_migrations from tests and C API
jsparber Apr 11, 2026
1df624c
Remove duplicated DiscoveryMode
jsparber Apr 11, 2026
999b3d6
Drop garbage files
jsparber Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed libp2panda/include/.p2panda.h.swo
View file
Open in desktop
Binary file not shown.
5 changes: 2 additions & 3 deletions libp2panda/include/p2panda.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ typedef enum
P2PANDA_TOPIC_FLAGS_PERSISTENT,
P2PANDA_TOPIC_FLAGS_EPHEMERAL,
P2PANDA_TOPIC_FLAGS_FROM_START,
} P2pandaMdnsDiscoveryMode;
} P2pandaTopicFlags;

GType p2panda_topic_flags_get_type(void);

Expand Down Expand Up @@ -307,8 +307,8 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(P2pandaRelayUrl, p2panda_relay_url_free)

/**
* p2panda_node_new:
* @private_key: (nullable): The private key to be used for this node
* @database_url: (nullable): A sqlite address
* @default_migrations: Whether to apply default migrations
* @network_id: (nullable): The network id of the network to join
* @relay_url: (nullable): The url of a iroh Relay Server
* @bootstrap_node_id: (nullable): The address of the bootstrap node
Expand All @@ -320,7 +320,6 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(P2pandaRelayUrl, p2panda_relay_url_free)
*/
P2pandaNode *p2panda_node_new(P2pandaPrivateKey *private_key,
const char *database_url,
gboolean default_migrations,
P2pandaNetworkId *network_id,
GUri *relay_url,
P2pandaNodeId *bootstrap_node_id,
Expand Down
10 changes: 0 additions & 10 deletions p2panda-gobject/src/boxed.rs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion p2panda-gobject/src/stream_handle.rs
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions tests/libp2panda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def main():
assert private_key
public_key = private_key.get_public_key()
assert public_key
node = P2panda.Node.new(private_key, None, True, network_id, None, None, P2panda.MdnsDiscoveryMode.ACTIVE)
node = P2panda.Node.new(private_key, None, network_id, None, None, P2panda.MdnsDiscoveryMode.ACTIVE)
assert node

global async_tests_remaining
Expand All @@ -32,7 +32,7 @@ def main():
node.spawn_async(None, node_spawn_cb, None);

private_key2 = P2panda.PrivateKey.new()
node2 = P2panda.Node.new(private_key2, None, True, network_id, None, None, P2panda.MdnsDiscoveryMode.ACTIVE)
node2 = P2panda.Node.new(private_key2, None, network_id, None, None, P2panda.MdnsDiscoveryMode.ACTIVE)
assert node2

node2.spawn_async(None, node2_spawn_cb, None);
Expand Down
Loading