[clickhouse] replicated and single-node config should match#10454
Merged
karencfv merged 2 commits intoMay 18, 2026
Conversation
jmcarp
approved these changes
May 18, 2026
Contributor
jmcarp
left a comment
jmcarp
left a comment
There was a problem hiding this comment.
Thanks for reconciling! For another time, I wonder if we should consolidate single and clustered config generation in clickhouse-admin—but maybe it's not worth doing if single-node is going away?
Contributor
Author
We've been saying it's going to go away for a couple of years now, and it hasn't yet 😄 If it's not more than an hour's worth of work, perhaps it's worth it if only to keep both configs in sync? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #10443 and #10450 . We should keep both configs in sync