Add Users & Groups page#3106
Closed
charliepark wants to merge 31 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
There are a few details in Figma I'm going to pull in next week, so moving this back to draft. |
Contributor
Author
|
Latest commit adds some more data to the sidebars: |
Contributor
Author
|
Ignore this; now moot |
charliepark
changed the title
Contributor
Author
|
A more updated version of this is over at #3211 |
Contributor
Author
|
Closing this, since #3211 covers this same ground |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm making a few changes to get this aligned with the designs in Figma.
We currently show a Project or Silo's "Roles", but that only shows a subset of the users or groups on a project/silo.
This PR updates that so people can see all of a silo's users or groups, even if no role has been assigned to them.
And Groups …
One note to call out is the n+1 on the Groups tab, where we're fetching the list of users in the group so we can generate a count of group members. Angela notes that we likely won't have more than about 5 groups per silo, so the n+1 impact here is pretty limited.
Closes #2887