Skip to content

Fix: Sort verified status-all builds first #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meumar-osec merged 4 commits into from
Jul 21, 2026
Merged

Fix: Sort verified status-all builds first #142

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
221796c
fix: optimize SQL query for retrieving builds by their status
swaroop-osec Jul 21, 2026
3ab789a
fix: update ordering of verification results to prioritize verified b…
swaroop-osec Jul 21, 2026
19e2805
fix: bump version to 2.0.3
swaroop-osec Jul 21, 2026
fb76016
chore: update changelog for version 2.0.3 with status-all endpoint ch…
swaroop-osec Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/db.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,20 +397,26 @@ impl DbClient {

/// One row per signer, preferring their build whose `executable_hash`
/// matches the on-chain hash (verified), else the most recent. Hash-less
/// builds are skipped.
/// builds are skipped. The returned rows are ordered with verified builds
/// first, then by signer for stable output.
pub async fn get_all_verification_info(
&self,
program_id: Address,
) -> Result<Vec<VerificationResponseWithSigner>> {
let state = self.get_program_state(&program_id).await?;
let on_chain_hash = state.as_ref().and_then(|s| s.on_chain_hash.clone());
let builds = sqlx::query_as::<_, BuildRow>(
"SELECT DISTINCT ON (signer) * FROM builds
WHERE program_id = $1 AND status = 'completed'
AND executable_hash IS NOT NULL
ORDER BY signer,
COALESCE(executable_hash = $2::text, false) DESC,
completed_at DESC NULLS LAST",
"WITH selected_builds AS (
SELECT DISTINCT ON (signer) * FROM builds
WHERE program_id = $1 AND status = 'completed'
AND executable_hash IS NOT NULL
ORDER BY signer,
COALESCE(executable_hash = $2::text, false) DESC,
completed_at DESC NULLS LAST
)
SELECT * FROM selected_builds
ORDER BY COALESCE(executable_hash = $2::text, false) DESC,
signer",
)
.bind(program_id)
.bind(&on_chain_hash)
Expand Down
Loading