fix(spl): pass collection account key in unverify_collection CPI - #4958
Open
spellsaif wants to merge 1 commit into
Open
fix(spl): pass collection account key in unverify_collection CPI#4958spellsaif wants to merge 1 commit into
spellsaif wants to merge 1 commit into
Conversation
spellsaif
requested review from
chen-robert,
jamie-osec and
renato-osec
as code owners
August 22, 2026 08:34
|
@spellsaif is attempting to deploy a commit to the OtterSec Team on Vercel. A member of the Team first needs to authorize it. |
swaroop-osec
approved these changes
Aug 24, 2026
0x4ka5h
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
anchor-spl/src/metadata.rs,unverify_collectionandunverify_sized_collection_itemincorrectly passedctx. accounts.metadata.keyas thecollectionfield inmpl_token_metadata::instructions::UnverifyCollectionandUnverifySizedCollectionItem.This ignored
ctx.accounts.collectionand caused the Metaplex CPI to fail on-chain because the item's own metadata account was being passed as the collection metadata account.Changes
unverify_collection, pass*ctx.accounts.collection.keytompl_token_metadata::instructions::UnverifyCollection.collection.unverify_sized_collection_item, pass*ctx.accounts.collection.keytompl_token_metadata::instructions::UnverifySizedCollectionItem.collection.Impact
anchor-spl.UnverifyCollectiondefinition.