fix(lang): Enforce mut constraint on Migration accounts - #4951
Open
spellsaif wants to merge 1 commit into
Open
Conversation
spellsaif
requested review from
chen-robert,
jamie-osec and
renato-osec
as code owners
August 20, 2026 13:03
|
@spellsaif is attempting to deploy a commit to the OtterSec Team on Vercel. A member of the Team first needs to authorize it. |
0x4ka5h
approved these changes
Aug 20, 2026
Collaborator
|
fix CI |
Author
|
@0x4ka5h can you rerun it again it. I think it is rate limit problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration<'info, From, To>relies onAccountsExit::exitto persist the migrated state to storage. Becauseexit.rsskips generating exit routines for non-mutable fields (match f.constraints.is_mutable() { false => quote! {} }), declaring aMigrationwithout#[account(mut)]resulted in silent state loss despite the instruction succeeding.This PR adds a compile-time check in
constraints_cross_checksrequiringMigrationaccounts to be markedmut.Testing
lang/syn/tests/migration_mut.rsverifying:Migrationwithout#[account(mut)]produces a compile-time parse error.Migrationwith#[account(mut)]parses successfully.cargo test -p anchor-synpassed.cargo clippy -p anchor-syn -- -D warningspassed (0 warnings).