fix(lang-v2): honor bytemuckunsafe in declare_program! imports - #4924
fix(lang-v2): honor bytemuckunsafe in declare_program! imports#4924akash-osec wants to merge 1 commit into
Conversation
|
@akash-osec is attempting to deploy a commit to the OtterSec Team on Vercel. A member of the Team first needs to authorize it. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## anchor-next #4924 +/- ##
==============================================
Coverage ? 64.65%
==============================================
Files ? 127
Lines ? 16618
Branches ? 0
==============================================
Hits ? 10744
Misses ? 5874
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| @@ -3545,6 +3553,10 @@ impl DeclareTypeSerialization { | |||
| fn is_bytemuck(self) -> bool { | |||
There was a problem hiding this comment.
Can we document that this matches [Self::BytemuckUnsafe] as well? It's not obvious from the name, especially given is_bytemuck_unsafe is now added
Fixing finding AI # 28
declare_program!collapsedbytemuckunsafeinto safebytemuck, so imported unsafe zero-copy types were rejected unless they were alreadyPodand padding-free. Now this PR keep safe bytemuck checks for bytemuck, and forbytemuckunsafeemit uncheckedPodimpls with v1’s packed default when repr is omitted.