fix(avm): paginate GitHub releases when listing versions - #4921
Open
questfever wants to merge 2 commits into
Open
fix(avm): paginate GitHub releases when listing versions#4921questfever wants to merge 2 commits into
questfever wants to merge 2 commits into
Conversation
questfever
requested review from
chen-robert,
jamie-osec and
renato-osec
as code owners
August 13, 2026 09:55
|
@questfever is attempting to deploy a commit to the OtterSec Team on Vercel. A member of the Team first needs to authorize it. |
jamie-osec
reviewed
Aug 15, 2026
jamie-osec
reviewed
Aug 15, 2026
Author
|
@jamie-osec Thanks! I dropped the test and updated pagination to use the response's Link header. It now stops when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_versions_with_clientcurrently makes a single request to GitHub's List releases endpoint. GitHub returns 30 releases by default, soavm listomits older published Anchor versions that are not present on the first page.The repository currently has more than 30 releases. For example, the second page contains releases from
v0.17.0throughv0.1.0, which are absent from the available-version list returned by AVM.This change:
pre-releases;
queried;
Using only
per_page=100would fix the current symptom but would reintroduce the bug once the repository exceeds 100 releases, so the implementation performs full pagination.Branch Target
master. This is a non-breaking bug fix.