Add better test for localStorage - #144
Merged
Merged
Conversation
Followup from #126 I added a mock `localStorage` for environments where localStorage isn't available, and to remove the 'store' dependency. I've been testing more with [Bun](https://bun.com/) and I found that there, this code doesn't reliably create the mock. I guess in Node trying to access `window.localStorage` would throw an exception, but that's not necessarily the case in other JS runtimes. This commit changes it to use the `if (!('localStorage' in globalThis))` syntax, which should work more reliably everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup from #126
I added a mock
localStoragefor environments where localStorage isn't available, and to remove the 'store' dependency.I've been testing more with Bun and I found that there, the previous code doesn't reliably create the mock. Attempting to access
window.localStoragewould throw an exception in Node, but that's not necessarily the case in other JS runtimes.This commit changes the check to use the
if (!('localStorage' in globalThis))syntax, which should work more reliably everywhere.