Skip to content

Restore anaconda-iso/iso type to bootc-image-builder #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brlane-rht wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Restore anaconda-iso/iso type to bootc-image-builder #2527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76e4b5e
generic: Make NewDistroYAMLFrom function public
brlane-rht Jul 16, 2026
48adc67
bib_legacy: Restore the legacy anaconda iso code
brlane-rht Jul 16, 2026
73061c1
bib: Use bib specific anaconda-iso code
brlane-rht Jul 16, 2026
17a26b7
tests: Don't skip anaconda-iso tests
brlane-rht Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions bootc-image-builder/test/test_build_iso.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
@pytest.mark.skipif(platform.system() != "Linux", reason="boot test only runs on linux right now")
@pytest.mark.parametrize("image_type", gen_testcases("anaconda-iso"), indirect=["image_type"])
@pytest.mark.skip(reason="kvm boot tests are currently disabled")
@pytest.mark.skip(reason="anaconda-iso is not supported")
def test_iso_installs(image_type):
installer_iso_path = image_type.img_path
test_disk_path = installer_iso_path.with_name("test-disk.img")
Expand Down Expand Up @@ -62,7 +61,6 @@ def osinfo_for(it: ImageBuildResult, arch: str) -> str:

@pytest.mark.skipif(platform.system() != "Linux", reason="osinfo detect test only runs on linux right now")
@pytest.mark.parametrize("image_type", gen_testcases("anaconda-iso"), indirect=["image_type"])
@pytest.mark.skip(reason="anaconda-iso is not supported")
def test_iso_os_detection(image_type):
installer_iso_path = image_type.img_path
arch = image_type.img_arch
Expand All @@ -80,7 +78,6 @@ def test_iso_os_detection(image_type):
@pytest.mark.skipif(platform.system() != "Linux", reason="osinfo detect test only runs on linux right now")
@pytest.mark.skipif(not testutil.has_executable("unsquashfs"), reason="need unsquashfs")
@pytest.mark.parametrize("image_type", gen_testcases("anaconda-iso"), indirect=["image_type"])
@pytest.mark.skip(reason="anaconda-iso is not supported")
def test_iso_install_img_is_squashfs(tmp_path, image_type):
installer_iso_path = image_type.img_path
with ExitStack() as cm:
Expand Down
6 changes: 0 additions & 6 deletions bootc-image-builder/test/test_manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ def test_manifest_smoke(build_container, tc):


@pytest.mark.parametrize("tc", gen_testcases("anaconda-iso"))
@pytest.mark.skip(reason="anaconda-iso is not supported")
def test_rpm_iso_manifest_smoke(build_container, tc):
testutil.pull_container(tc.container_ref, tc.target_arch)

Expand Down Expand Up @@ -266,7 +265,6 @@ def test_manifest_user_customizations_toml(tmp_path, build_container):
}


@pytest.mark.skip(reason="anaconda-iso is not supported")
def test_manifest_installer_customizations(tmp_path, build_container):
container_ref = "quay.io/centos-bootc/centos-bootc:stream9"
testutil.pull_container(container_ref)
Expand Down Expand Up @@ -398,7 +396,6 @@ def find_image_anaconda_stage(manifest_str):


@pytest.mark.parametrize("tc", gen_testcases("anaconda-iso"))
@pytest.mark.skip(reason="anaconda-iso is not supported")
def test_manifest_anaconda_module_customizations(tmpdir_factory, build_container, tc):
testutil.pull_container(tc.container_ref, tc.target_arch)

Expand Down Expand Up @@ -604,7 +601,6 @@ def find_grub2_iso_stage_from(manifest_str):
raise ValueError(f"cannot find grub2.iso stage in manifest:\n{manifest_str}")


@pytest.mark.skip(reason="anaconda-iso is not supported")
def test_manifest_fips_customization(tmp_path, build_container):
container_ref = "quay.io/centos-bootc/centos-bootc:stream9"
testutil.pull_container(container_ref)
Expand Down Expand Up @@ -824,7 +820,6 @@ def test_manifest_disk_customization_lvm_swap(tmp_path, build_container):


@pytest.mark.parametrize("use_librepo", [False, True])
@pytest.mark.skip(reason="anaconda-iso is not supported")
def test_iso_manifest_use_librepo(build_container, use_librepo):
# no need to parameterize this test, --use-librepo behaves same for all containers
container_ref = "quay.io/centos-bootc/centos-bootc:stream9"
Expand Down Expand Up @@ -1083,7 +1078,6 @@ def test_manifest_image_disk_yaml(tmp_path, build_container):


@pytest.mark.parametrize("tc", gen_testcases("anaconda-iso"))
@pytest.mark.skip(reason="anaconda-iso is not supported")
def test_ova_manifest_smoke(build_container, tc):
testutil.pull_container(tc.container_ref, tc.target_arch)

Expand Down
Loading
Loading