Skip to content

fix(run): resolve bundled binary on Windows Git Bash / MSYS2 / Cygwin #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keith-mvs wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(run): resolve bundled binary on Windows Git Bash / MSYS2 / Cygwin #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93be76d
fix(run): resolve bundled binary on Windows Git Bash / MSYS2 / Cygwin
keith-mvs Jun 4, 2026
f972ac9
ci: pin ollama/ollama to 0.24.0 for reproducible embedding snapshots
keith-mvs Jun 4, 2026
a06abaa
ci: clarify pinned ollama digest is the multi-arch index digest
keith-mvs Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,15 @@ jobs:
if: github.actor != 'release-please[bot]'
services:
ollama:
image: ollama/ollama:latest
# Pin the embedding runtime. The lang E2E suite (TestLang_*) asserts on
# committed embedding snapshots (testdata/snapshots/), so all-minilm must
# return identical vectors run-to-run. The `:latest` tag drifted from
# 0.24.0 to a newer build between 2026-05-20 and 2026-06-04, which shifted
# the ranked results and broke every snapshot. 0.24.0 is the last runtime
# the snapshots were verified green against (== the multi-arch index
# digest that `docker pull` resolves the 0.24.0 tag to:
# sha256:a6149234667efc71d37766d61c1a16f24c33e4cd7a0bf4125c44a7e47e2419c4).
image: ollama/ollama:0.24.0
Comment thread
keith-mvs marked this conversation as resolved.
ports:
- 11434:11434
steps:
Expand Down
15 changes: 12 additions & 3 deletions scripts/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,20 @@ case "$ARCH" in
aarch64) ARCH="arm64" ;;
esac

# Normalize Windows-flavored uname. Git Bash/MSYS2/Cygwin report uname -s as
# mingw*/msys*/cygwin* (and embed the Windows build number), not "windows", and
# their binaries carry a .exe suffix. Without this the loop below misses the
# bundled bin/lumen-windows-amd64.exe and falls through to a doomed download.
EXT=""
case "$OS" in
mingw*|msys*|cygwin*|windows*) OS="windows"; EXT=".exe" ;;
esac

# Find binary: check bin/ first, then goreleaser dist/ output, then download
BINARY=""
for candidate in \
"${PLUGIN_ROOT}/bin/lumen" \
"${PLUGIN_ROOT}/bin/lumen-${OS}-${ARCH}"; do
"${PLUGIN_ROOT}/bin/lumen${EXT}" \
"${PLUGIN_ROOT}/bin/lumen-${OS}-${ARCH}${EXT}"; do
if [ -x "$candidate" ]; then
BINARY="$candidate"
break
Expand All @@ -27,7 +36,7 @@ done

# Download on first run if no binary found
if [ -z "$BINARY" ]; then
BINARY="${PLUGIN_ROOT}/bin/lumen-${OS}-${ARCH}"
BINARY="${PLUGIN_ROOT}/bin/lumen-${OS}-${ARCH}${EXT}"

REPO="ory/lumen"

Expand Down
Loading