Skip to content

pkgconfig: fix parsing default search path#29

Closed
D-Alex wants to merge 1 commit into
masterfrom
pkgconfig
Closed

pkgconfig: fix parsing default search path#29
D-Alex wants to merge 1 commit into
masterfrom
pkgconfig

Conversation

@D-Alex

@D-Alex D-Alex commented Feb 19, 2016

Copy link
Copy Markdown
Member

pkg-config 0.29 reports the scanning directory differently than for example
pkg-config 0.26 (Ubuntu 14.04)

pkg-config 0.29:

Scanning directory #3 '/usr/local/lib/pkgconfig'

pkg-config 0.26:

Scanning directory '/usr/local/lib/pkgconfig'

pkg-config 0.29 reports the scanning directory differently:

Scanning directory #3 '/usr/local/lib/pkgconfig'
instead of
Scanning directory '/usr/local/lib/pkgconfig'
@doudou

doudou commented Feb 22, 2016

Copy link
Copy Markdown
Contributor

Shouldn't we just do [^']* ?

@doudou doudou mentioned this pull request May 2, 2016
@doudou doudou mentioned this pull request Jun 9, 2016
@doudou

doudou commented Jun 9, 2016

Copy link
Copy Markdown
Contributor

I preferred changing the way the prefix is matched to a more grouped approach (which is narrower), and added tests. See #32.

@doudou doudou closed this Jun 9, 2016
@doudou doudou deleted the pkgconfig branch October 19, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants