Skip to content

Add esbuild bundle script#963

Closed
isaachinman wants to merge 1 commit into
oramasearch:mainfrom
isaachinman:main
Closed

Add esbuild bundle script#963
isaachinman wants to merge 1 commit into
oramasearch:mainfrom
isaachinman:main

Conversation

@isaachinman

Copy link
Copy Markdown

Fixes #961

@vercel

vercel Bot commented Aug 19, 2025

Copy link
Copy Markdown

@isaachinman is attempting to deploy a commit to the OramaSearch Team on Vercel.

A member of the Team first needs to authorize it.

@micheleriva

Copy link
Copy Markdown
Contributor

I'll review this asap, sorry for the delay 🙏

@thatjuan

Copy link
Copy Markdown
Contributor

Superseded by #1026, now merged. Rather than shipping a bundled artifact, #1026 fixes this at the source: it extracts fetchDocuments/fetchDocumentsWithDistinct out of methods/search.ts into their own module so the per-mode search modules no longer import search.ts back — removing the circular dependency entirely. That fixes it for every bundler (no bundle export condition or esbuild postbuild for consumers to opt into) and keeps the build bundler-free, which avoids the ESM↔CJS concern raised in #961. Thanks for the clear repro and the example PR — they made the root cause easy to pin down. Closing in favor of #1026.

@thatjuan thatjuan closed this Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circular dependencies / require cycle

3 participants