Corrects missing is_shareable attribute in results from data source oci_core_volume_attachments #2191 - #2197
Corrects missing is_shareable attribute in results from data source oci_core_volume_attachments #2191#2197jeliker1 wants to merge 1 commit into
is_shareable attribute in results from data source oci_core_volume_attachments #2191#2197Conversation
…me_attachments` ref oracle#2191 Update data source documentation for `oci_core_volume_attachments` Signed-off-by: Jon-Eric Eliker <jeliker@mythics.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
|
Thank you for your valuable contribution. We greatly appreciate your efforts in submitting this pull request. However, I regret to inform you that we are unable to merge it directly on GitHub at this time. Our internal policy requires that all pull requests undergo thorough local testing and review before they can be merged into the main codebase. This process ensures the quality and stability of Terraform-Provider-OCI. We understand that this may cause some inconvenience, but please rest assured that your contribution is highly valued. Our team will carefully review and test your changes locally to ensure they meet our standards. We appreciate your understanding and patience in this matter. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you once again for your contribution. |
|
Thank you for signing the OCA. |
|
@tf-oci-pub hoping someone has opportunity for review. I think the change is quite simple and logical making me think the review ought to be a low-effort task. |
|
Looks like this got fixed through other means and pull request is no longer necessary. Can you confirm? |
Data source
oci_core_volume_attachmentsis missingis_shareableattribute so that it returnsfalsefor all results. This change adds the missing attribute and updates related documentation to indicate inclusion of the attribute.