[GenAI] Add support for org.springframework.data:spring-data-commons:2.7.18 using gpt-5.5 (chunked dynamic-access) - #8830
Conversation
…g.model.InstanceCreatorMetadataDiscoverer
…g.model.PreferredConstructorDiscoverer$Discoverers$1
…assGeneratingPropertyAccessorFactory (11/36)
…g.model.ClassGeneratingPropertyAccessorFactory
…tion.DefaultMethodInvokingMethodInterceptor$MethodHandleLookup$1
…on.DefaultMethodInvokingMethodInterceptor$MethodHandleLookup (1/2)
…tion.DefaultMethodInvokingMethodInterceptor$MethodHandleLookup
…tion.DefaultMethodInvokingMethodInterceptor$MethodHandleLookup$2
…tory.core.support.RepositoryFragment
…tory.util.ReactiveWrappers
…support.DefaultRepositoryInformation (17/36)
…DefaultRepositoryInformation__native_batch_5
…tory.core.support.DefaultRepositoryInformation
…support.RepositoryMethodInvoker$RepositoryFragmentMethodInvoker (19/38)
…tory.core.support.RepositoryMethodInvoker$RepositoryFragmentMethodInvoker
…g.model.PreferredConstructorDiscoverer$Discoverers$2
…tlinCopyMethod (22/38)
…g.model.KotlinCopyMethod
…rParser$FilterType$1 (23/38)
….TypeFilterParser$FilterType$1
…FilterType$1__native_batch_3
…data-commons:2.7.18
…a:spring-data-commons:2.7.18
kimeta
left a comment
There was a problem hiding this comment.
Requesting changes because this PR introduces a new downstream native-image regression. The affected Spring AOT smoke tests :data:data-web-support, :security:security-ldap, and :security:ldap-odm are all passing upstream but fail here with Type not found during analysis: HotSpotType<Lorg/springframework/data/repository/kotlin/CoroutineCrudRepository;, resolved>. I also reran the required final validateIndexFiles check against the merged origin/master candidate, and that passed.
| @Test | ||
| void adaptsSuspendingRepositoryMethodToReactiveFragmentMethod() throws Exception { | ||
| ReactiveCounter fragment = new ReactiveCounter(); | ||
| Method declaredMethod = CoroutineCrudRepository.class.getMethod("count", Continuation.class); |
There was a problem hiding this comment.
This CoroutineCrudRepository coverage is introducing a real downstream regression. The affected Spring AOT smoke tests :data:data-web-support, :security:security-ldap, and :security:ldap-odm all fail as new regressions with Type not found during analysis: HotSpotType<Lorg/springframework/data/repository/kotlin/CoroutineCrudRepository;, resolved>. Please avoid emitting metadata that requires this optional Kotlin repository interface unless the PR also proves it is safe for downstream native-image builds.
kimeta
left a comment
There was a problem hiding this comment.
Reviewed the gh pr diff for the single org.springframework.data:spring-data-commons:2.7.18 addition and found no blocking issues. Local checkMetadataFiles -Pcoordinates=org.springframework.data:spring-data-commons:2.7.18, final validateIndexFiles -Pcoordinates=all on current origin/master plus PR #8830, and test -Pcoordinates=org.springframework.data:spring-data-commons:2.7.18 all passed.
kimeta
left a comment
There was a problem hiding this comment.
Requesting changes because this PR introduces a downstream native-image regression. The affected Spring AOT smoke tests :data:data-web-support, :security:security-ldap, and :security:ldap-odm fail on this PR with a CoroutineCrudRepository analysis failure, so the new RepositoryMethodInvoker metadata is not safe to merge as-is. Final validateIndexFiles against current origin/master passed.
kimeta
left a comment
There was a problem hiding this comment.
Requesting changes because this PR introduces a downstream native-image regression. The affected Spring AOT smoke tests :data:data-web-support, :security:security-ldap, and :security:ldap-odm fail on this PR with Type not found during analysis: HotSpotType<Lorg/springframework/data/repository/kotlin/CoroutineCrudRepository;, resolved>. Local ./gradlew checkMetadataFiles -Pcoordinates=org.springframework.data:spring-data-commons:2.7.18 and ./gradlew test -Pcoordinates=org.springframework.data:spring-data-commons:2.7.18 both pass, so the target coordinate is covered, but the new RepositoryMethodInvoker / CoroutineCrudRepository metadata is not safe to merge as-is.
What does this PR do?
Refs: #2813
This PR introduces tests and metadata for org.springframework.data:spring-data-commons:2.7.18, enabling support for this library.
Summary:
Forge
origin/mastermaster9260397b835806a526cfb0574d5549f956ced0e0Stats from
stats/<groupId>/<artifactId>/<metadata-version>/stats.json:Dynamic access coverage:
Library coverage:
Local CI Verification
success