Added eco-tests for indexer + CI job to notify the indexer team#2624
Added eco-tests for indexer + CI job to notify the indexer team#2624evgeny-s wants to merge 9 commits into
Conversation
eco-tests changed — indexer review requiredThis PR modifies files under Changed files
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE BASELINE scrutiny: established write-permission contributor, no Gittensor allowlist match found; branch eco-tests-indexers -> devnet-ready. Reviewed the new eco-tests notification workflow, test-only runtime API mocks, and eco-tests dependency additions. The workflow is FindingsNo findings. ConclusionNo malicious behavior or security vulnerability was found. The diff is limited to a reviewer-notification workflow and test-only indexer contract coverage. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Static review found this remains scoped to eco-test contract coverage plus a notification workflow; no runtime/pallet behavior changes or spec-version bump requirement. I reviewed the refreshed diff, PR metadata, prior Auditor comment, author context, dependency lock state, and overlapping PR list from No auto-fixes were needed on this rerun. I did not run broad build/test commands because the diff is test/workflow-only and static review did not surface a finding requiring runtime confirmation. FindingsNo findings. ConclusionThe PR adds compile-time contract tests for indexer-facing storage/API shapes and a targeted reviewer notification workflow without changing runtime behavior. I found no domain-blocking issues. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
| pallet-subtensor-swap-runtime-api = { path = "../pallets/swap/runtime-api", default-features = false, features = ["std"] } | ||
| subtensor-custom-rpc-runtime-api = { path = "../pallets/subtensor/runtime-api", default-features = false, features = ["std"] } | ||
| sp-api = { git = "https://github.com/opentensor/polkadot-sdk.git", rev = "7cc54bf2d50ae3921d718736dfeb0de9468539c7", default-features = false, features = ["std"] } |
There was a problem hiding this comment.
I don't know why the decision was made to have a purely independent crate here but I think we should add it to the workspace so we can use { workspace = true } and centralize the dependencies in the root Cargo.toml. Much easier for upgrade too. Wdyt?
Description
This PR adds contract-style tests for the storage maps and runtime APIs consumed by the TAO.com indexer, plus a CI workflow that pings the responsible reviewer(-s) whenever those tests change. It detects storage items, renames, retypes, key shape changes, and runtime api signature changes.
Tested here.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.