Add TLS certificate for InstanceHA metrics endpoint#1932
Conversation
OpenStackControlPlane CRD Size Report
Threshold reference
|
lmiccini
force-pushed
the
add-instanceha-metrics-tls
branch
from
92fc786 to
4d9373d
Compare
|
/test openstack-operator-build-deploy-kuttl-4-18 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, lmiccini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test openstack-operator-build-deploy-kuttl-4-18 |
lmiccini
force-pushed
the
add-instanceha-metrics-tls
branch
from
4d9373d to
cd92131
Compare
|
New changes are detected. LGTM label has been removed. |
lmiccini
force-pushed
the
add-instanceha-metrics-tls
branch
from
cd92131 to
e55ccde
Compare
|
@lmiccini: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test functional |
lmiccini
force-pushed
the
add-instanceha-metrics-tls
branch
from
e55ccde to
e2c05f8
Compare
| err.Error())) | ||
| return ctrl.Result{}, err | ||
| } | ||
| instance.Status.Conditions.Set(condition.TrueCondition( |
There was a problem hiding this comment.
@lmiccini are these conditions initialized somewhere to Unknown? Maybe it doesn't matter as they're not part of the main condition pool.
There was a problem hiding this comment.
no they are not, they're just cosmetic and set during reconcile to signal stuff is ready or not
Create a cert-manager Certificate for the InstanceHA metrics service when pod-level TLS is enabled. The certificate uses the internal issuer with wildcard hostnames for the namespace, following the same pattern as EnsureOVNMetricsCert. The resulting secret (cert-instanceha-metrics) is consumed by the infra-operator InstanceHA controller. Also add the cert-instanceha-metrics secret to functional tests so the reconciler does not block waiting for cert-manager in envtest. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lmiccini
force-pushed
the
add-instanceha-metrics-tls
branch
from
e2c05f8 to
c1d365d
Compare
3 participants
Create a cert-manager Certificate for the InstanceHA metrics service when pod-level TLS is enabled. The certificate uses the internal issuer with wildcard hostnames for the namespace, following the same pattern as EnsureOVNMetricsCert. The resulting secret (cert-instanceha-metrics) is consumed by the infra-operator InstanceHA controller.