Skip to content

CNTRLPLANE-772: Add request serving test to HCM periodics #79884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiezhao16 wants to merge 2 commits into
base: main
Choose a base branch
from
+89 −0
Open

CNTRLPLANE-772: Add request serving test to HCM periodics #79884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfed648
Add request serving test to HCM periodics for 4.21
jiezhao16 May 29, 2026
ca28fa2
Add request serving test to HCM periodics for 4.21
jiezhao16 May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...perator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-hcm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ tests:
steps:
cluster_profile: hypershift-aws
workflow: hypershift-aws-e2e-external
- as: e2e-aws-request-serving
cron: 0 4 * * *
steps:
cluster_profile: hypershift-aws
env:
REQUEST_SERVING_COMPONENT_TEST: "true"
workflow: hypershift-aws-e2e-metrics
Comment on lines +41 to +47
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify whether this PR includes generated ci-operator/jobs changes for the new periodic test.
# Expected: at least one changed file under ci-operator/jobs/ for structural test additions.

git diff --name-only -- ci-operator/config ci-operator/jobs | sed 's#^`#-` #'
echo
echo "Changed generated job files:"
git diff --name-only -- ci-operator/jobs | sed 's#^`#-` #'

Repository: openshift/release

Length of output: 91

Regenerate and include Prow job configs for e2e-aws-request-serving.
The new periodic test entry (e2e-aws-request-serving, lines 41-47) was added to ci-operator/config, but no regenerated changes under ci-operator/jobs/** are included—please run make update and commit the generated artifacts, or provide evidence that regeneration intentionally produced no diffs.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-hcm.yaml`
around lines 41 - 47, The new periodic job "e2e-aws-request-serving" was added
to ci-operator config but the generated Prow job artifacts under
ci-operator/jobs were not updated; run the repository's job generation (e.g.,
execute make update or the project’s generation target) to regenerate Prow job
configs, verify the generated changes include the new periodic job, and commit
those generated files (or if generation intentionally yields no diffs, add a
short note/evidence in the PR describing why no generated changes occurred);
ensure the job name "e2e-aws-request-serving" appears in the regenerated
artifacts before finalizing the PR.

- as: e2e-aws-upgrade-minor
cron: 0 1 * * *
steps:
Expand Down
82 changes: 82 additions & 0 deletions ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.21-periodics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3068,6 +3068,88 @@ periodics:
- name: result-aggregator
secret:
secretName: result-aggregator
- agent: kubernetes
cluster: build01
cron: 0 4 * * *
decorate: true
decoration_config:
skip_cloning: true
extra_refs:
- base_ref: release-4.21
org: openshift
repo: hypershift
labels:
ci-operator.openshift.io/cloud: hypershift-aws
ci-operator.openshift.io/cloud-cluster-profile: hypershift-aws
ci-operator.openshift.io/variant: periodics-hcm
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: periodic-ci-openshift-hypershift-release-4.21-periodics-hcm-e2e-aws-request-serving
spec:
containers:
- args:
- --gcs-upload-secret=/secrets/gcs/service-account.json
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
- --lease-server-credentials-file=/etc/boskos/credentials
- --report-credentials-file=/etc/report/credentials
- --secret-dir=/secrets/ci-pull-credentials
- --target=e2e-aws-request-serving
- --variant=periodics-hcm
command:
- ci-operator
env:
- name: HTTP_SERVER_IP
valueFrom:
fieldRef:
fieldPath: status.podIP
image: quay-proxy.ci.openshift.org/openshift/ci:ci_ci-operator_latest
imagePullPolicy: Always
name: ""
ports:
- containerPort: 8080
name: http
resources:
requests:
cpu: 10m
volumeMounts:
- mountPath: /etc/boskos
name: boskos
readOnly: true
- mountPath: /secrets/ci-pull-credentials
name: ci-pull-credentials
readOnly: true
- mountPath: /secrets/gcs
name: gcs-credentials
readOnly: true
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
serviceAccountName: ci-operator
volumes:
- name: boskos
secret:
items:
- key: credentials
path: credentials
secretName: boskos-credentials
- name: ci-pull-credentials
secret:
secretName: ci-pull-credentials
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
- agent: kubernetes
cluster: build01
cron: 0 2 * * *
Expand Down