Skip to content

openshift-logging: Add configuration for Loki v3.7.2#79874

Open
JoaoBraveCoding wants to merge 2 commits into
openshift:mainfrom
JoaoBraveCoding:loki-372
Open

openshift-logging: Add configuration for Loki v3.7.2#79874
JoaoBraveCoding wants to merge 2 commits into
openshift:mainfrom
JoaoBraveCoding:loki-372

Conversation

@JoaoBraveCoding
Copy link
Copy Markdown
Contributor

@JoaoBraveCoding JoaoBraveCoding commented May 29, 2026

/cc @xperimental

Summary by CodeRabbit

This PR updates OpenShift CI/infrastructure configuration to add build and image-mirroring support for Loki v3.7.2 in the OpenShift logging stack.

Infrastructure changes and practical effects:

  • CI-operator configuration (ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml):

    • Adds an upstream CI job to build and promote loki:v3.7.2.
    • Uses RHEL 9 base (base: 4.21, tag: base-rhel9) and the builder image rhel-9-golang-1.26-openshift-5.0 (Go 1.26).
    • Builds the image from Dockerfile.ocp, adds arm64 as an additional architecture, and promotes the resulting image to the logging namespace with tag v3.7.2.
    • Configures unit tests (GOFLAGS="" make test from src) and default resource requests.
    • Includes generated metadata linking branch upstream-v3.7.2 to openshift/loki and maps the job to OpenShift stable channel 4.21 in releases metadata.
  • Image mirroring mapping (core-services/image-mirroring/openshift-logging/mapping_logging_loki_quay):

    • Adds mapping for logging_loki_v3.7.2 → quay.io/openshift-logging/loki:v3.7.2 and also sets that image as quay.io/openshift-logging/loki:latest (rolling alias).
    • Ensures promtail v3.6.5 maps to both its versioned tag and the rolling promtail:latest alias.

Effect: OpenShift's CI will build, test, and promote Loki v3.7.2 (multi-arch) and update public quay.io mappings so v3.7.2 becomes the current rolling release for Loki in the OpenShift logging image stream.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9eeed107-3468-431f-9a68-0693adca499f

📥 Commits

Reviewing files that changed from the base of the PR and between 407595d and 299a1e4.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml

Walkthrough

This PR adds a CI-operator configuration to build, test, and promote Loki upstream v3.7.2 and updates image-mirroring mappings to route the new Loki tag and refresh Promtail aliasing.

Changes

Loki v3.7.2 Release Infrastructure

Layer / File(s) Summary
CI operator configuration for v3.7.2 build and promotion
ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml
Defines complete OpenShift CI-operator configuration for Loki v3.7.2, including base image with RHEL 9 and Golang toolchain, multi-architecture build settings (amd64 and arm64), image promotion to specified namespace/tag, stable release version mapping to 4.21, resource defaults, and unit test execution via make test.
Image mirroring mappings for v3.7.2 and Promtail updates
core-services/image-mirroring/openshift-logging/mapping_logging_loki_quay
Updates Quay image mirroring mappings to route Loki v3.7.2 and to alias Loki/Promtail versioned images to their latest rolling tags; replaces prior v3.6.5 mapping with the new entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change in the pull request: adding configuration for Loki v3.7.2 across both CI-operator and image-mirroring files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR adds configuration files (YAML CI-operator config and image mapping) for Loki v3.7.2. No Ginkgo test files are added or modified, so the check for stable test names is not applicable.
Test Structure And Quality ✅ Passed This PR contains no Ginkgo test code. Changes are limited to configuration files (YAML, image mapping) for Loki v3.7.2, which are not subject to the Ginkgo test quality check.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added in this PR. The changes are configuration files (CI operator YAML) and image mapping metadata, not test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR adds CI configuration and image mappings for Loki v3.7.2. No Ginkgo e2e tests are added, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds CI-operator build config and image mirroring mapping for Loki v3.7.2—not deployment manifests, operator code, or controllers. Check applies only to those artifact types.
Ote Binary Stdout Contract ✅ Passed PR only adds YAML configuration and image mapping files with no Go code or test binaries that could violate OTE binary stdout contracts.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only CI configuration and image mapping files; no Ginkgo e2e tests are added, so the IPv6 and disconnected network compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The PR modifies only CI/CD configuration and image mapping files with no cryptographic code, weak algorithms, custom crypto implementations, or insecure comparisons.
Container-Privileges ✅ Passed No privileged container configurations found. PR adds CI-operator config and image mapping files without any Kubernetes manifests or privileged container definitions.
No-Sensitive-Data-In-Logs ✅ Passed Configuration files contain no logging statements or sensitive data such as passwords, tokens, API keys, PII, or secrets.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from alanconway and jcantrill May 29, 2026 14:26
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JoaoBraveCoding
Once this PR has been reviewed and has the lgtm label, please assign xperimental for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@JoaoBraveCoding: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-loki-upstream-v3.7.2-images openshift/loki presubmit Presubmit changed
pull-ci-openshift-loki-upstream-v3.7.2-test openshift/loki presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

@JoaoBraveCoding: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant