SRVKP-11810: Add OpenShift CI configuration for openshift-pipelines/release-tests-ginkgo#79867
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (12)
✅ Files skipped from review due to trivial changes (5)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds OpenShift Pipelines release-tests-ginkgo job, prow plugin config, and two step-registry entries (install and tests) with OWNER metadata and runner scripts that authenticate, derive cluster URLs, run Ginkgo suites, and emit JUnit/artifact outputs. ChangesGinkgo test infrastructure
🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anithapriyanatarajan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @anithapriyanatarajan. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
Bot
added
the
do-not-merge/invalid-owners-file
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/config/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main__openshift-pipelines-ocp4.21-e2e-osp.yaml (1)
16-55:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the missing
promotionsection to match CI config requirements.This config defines
build_root,images,tests, andreleases, but omitspromotion, which violates the CI config checklist in this PR’s review guidelines.As per coding guidelines: “CI configuration files should define
build_root,images,tests,promotion, andreleasessections following the CI operator configuration specification”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main__openshift-pipelines-ocp4.21-e2e-osp.yaml` around lines 16 - 55, This file is missing the top-level promotion section required by the CI operator spec; add a "promotion" key (alongside the existing build_root/images/tests/releases entries) that follows the repo's promotion schema — include required fields such as name/namespace/tag or promote: true and any additional_images or tag_specification entries expected by your CI (mirror the pattern used in other release-tests-ginkgo CI configs) so the job (tests: - as: openshift-pipelines-e2e-osp) can be promoted correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-commands.sh`:
- Around line 5-10: The script currently dereferences KUBECONFIG directly in the
if test which will cause an exit under set -u; update the conditional to use a
safe parameter expansion (e.g. ${KUBECONFIG-} or ${KUBECONFIG:-}) so the test
doesn't trigger a premature exit, leaving the ROSA/Hypershift fallback login
intact; specifically modify the if test that references KUBECONFIG in the
ginkgo-install command block (the if [ -s "..." ]; then ... else ... fi) to use
the safe expansion and apply the same pattern to any other direct KUBECONFIG
dereferences in this script.
In
`@ci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-commands.sh`:
- Around line 5-10: The KUBECONFIG check is not nounset-safe and will fail under
set -u; change the condition to use parameter expansion defaults so it won't
error when KUBECONFIG is unset (e.g. replace the line if [ -s "${KUBECONFIG}" ];
then with a nounset-safe check such as if [ -n "${KUBECONFIG:-}" ] && [ -s
"${KUBECONFIG:-}" ]; then or simply if [ -s "${KUBECONFIG:-}" ]; then), leaving
the oc whoami and the fallback login via eval "$(cat "${SHARED_DIR}/api.login")"
unchanged.
---
Outside diff comments:
In
`@ci-operator/config/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main__openshift-pipelines-ocp4.21-e2e-osp.yaml`:
- Around line 16-55: This file is missing the top-level promotion section
required by the CI operator spec; add a "promotion" key (alongside the existing
build_root/images/tests/releases entries) that follows the repo's promotion
schema — include required fields such as name/namespace/tag or promote: true and
any additional_images or tag_specification entries expected by your CI (mirror
the pattern used in other release-tests-ginkgo CI configs) so the job (tests: -
as: openshift-pipelines-e2e-osp) can be promoted correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 48f0ca7b-5822-4961-a42f-43113f5ea6b8
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (10)
ci-operator/config/openshift-pipelines/release-tests-ginkgo/OWNERSci-operator/config/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main__openshift-pipelines-ocp4.21-e2e-osp.yamlci-operator/step-registry/openshift-pipelines/ginkgo-install/OWNERSci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-commands.shci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-ref.metadata.jsonci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-ref.yamlci-operator/step-registry/openshift-pipelines/ginkgo-tests/OWNERSci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-commands.shci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-ref.metadata.jsonci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-ref.yaml
anithapriyanatarajan
force-pushed
the
ci-pipelines-release-test
branch
from
a5f8a14 to
5e01f57
Compare
openshift-ci
Bot
removed
the
do-not-merge/invalid-owners-file
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-commands.sh`:
- Around line 15-30: Close the unclosed subshell and ensure sensitive values are
captured while tracing is disabled: add the missing closing ')' to match the '('
that starts the subshell, and move the re-enabling of tracing (set -x) to after
the CONSOLE_URL and API_URL assignments so CONSOLE_URL and API_URL are
assigned/exported while set +x is still in effect; reference the subshell that
begins with '(' and the variables CONSOLE_URL and API_URL along with the set +x
/ set -x calls when applying the fix.
In
`@ci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-commands.sh`:
- Around line 15-29: The subshell opened with "(set +x" is never closed and set
-x is re-enabled while CONSOLE_URL and API_URL are still being assigned, which
leaks sensitive cluster URLs; close the subshell after capturing the values
(i.e., put a ")" immediately after the API_URL assignment) so the sensitive
assignments occur inside the set +x protected subshell, then re-enable tracing
(set -x) only afterward before invoking ginkgo run; ensure the ginkgo run uses
the exported CONSOLE_URL and API_URL but those assignments remain inside the
protected subshell to avoid printing them.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 13a6ecac-de12-4626-82f7-ccb57fd3ff02
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (10)
ci-operator/config/openshift-pipelines/release-tests-ginkgo/OWNERSci-operator/config/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main__openshift-pipelines-ocp4.21-e2e-osp.yamlci-operator/step-registry/openshift-pipelines/ginkgo-install/OWNERSci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-commands.shci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-ref.metadata.jsonci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-ref.yamlci-operator/step-registry/openshift-pipelines/ginkgo-tests/OWNERSci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-commands.shci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-ref.metadata.jsonci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-ref.yaml
✅ Files skipped from review due to trivial changes (6)
- ci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-ref.metadata.json
- ci-operator/step-registry/openshift-pipelines/ginkgo-tests/OWNERS
- ci-operator/step-registry/openshift-pipelines/ginkgo-install/OWNERS
- ci-operator/config/openshift-pipelines/release-tests-ginkgo/OWNERS
- ci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-ref.metadata.json
- ci-operator/config/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main__openshift-pipelines-ocp4.21-e2e-osp.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- ci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-ref.yaml
- ci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-ref.yaml
anithapriyanatarajan
changed the title
|
@anithapriyanatarajan: This pull request references SRVKP-11810 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
anithapriyanatarajan
force-pushed
the
ci-pipelines-release-test
branch
from
5e01f57 to
be99504
Compare
| memory: 200Mi | ||
| tests: | ||
| - as: openshift-pipelines-e2e-osp | ||
| cron: 0 0 * * * |
There was a problem hiding this comment.
This is a cron job. Could you confirm if the intention is for PR CI or weekly jobs?
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-ref.yaml`:
- Around line 21-23: Update the documentation block so it accurately reflects
the actual entrypoint: replace the reference to "scripts/run-tests.sh" with a
note that the release-tests-ginkgo suite is invoked directly with "ginkgo run"
(as used by the paired commands file) and mention any relevant flags or test
path pattern (e.g., running tests/... via ginkgo run) so readers are directed to
the correct invocation point rather than the nonexistent script.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 9561c24b-13e2-4727-a44c-aa1df34b3185
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (10)
ci-operator/config/openshift-pipelines/release-tests-ginkgo/OWNERSci-operator/config/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main__openshift-pipelines-ocp4.21-e2e-osp.yamlci-operator/step-registry/openshift-pipelines/ginkgo-install/OWNERSci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-commands.shci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-ref.metadata.jsonci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-ref.yamlci-operator/step-registry/openshift-pipelines/ginkgo-tests/OWNERSci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-commands.shci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-ref.metadata.jsonci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-ref.yaml
✅ Files skipped from review due to trivial changes (5)
- ci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-ref.metadata.json
- ci-operator/step-registry/openshift-pipelines/ginkgo-tests/OWNERS
- ci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-ref.metadata.json
- ci-operator/config/openshift-pipelines/release-tests-ginkgo/OWNERS
- ci-operator/step-registry/openshift-pipelines/ginkgo-install/OWNERS
🚧 Files skipped from review as they are similar to previous changes (2)
- ci-operator/step-registry/openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-ref.yaml
- ci-operator/config/openshift-pipelines/release-tests-ginkgo/openshift-pipelines-release-tests-ginkgo-main__openshift-pipelines-ocp4.21-e2e-osp.yaml
| documentation: |- | ||
| Runs OpenShift Pipelines e2e tests using the Ginkgo-based | ||
| release-tests-ginkgo test suite (tests/...) via scripts/run-tests.sh. |
There was a problem hiding this comment.
Fix the step documentation to match the actual entrypoint.
This ref says the suite runs via scripts/run-tests.sh, but the paired commands file invokes ginkgo run directly. That mismatch will send anyone debugging this step to the wrong path.
📝 Suggested doc fix
documentation: |-
Runs OpenShift Pipelines e2e tests using the Ginkgo-based
- release-tests-ginkgo test suite (tests/...) via scripts/run-tests.sh.
+ release-tests-ginkgo test suite (tests/...) by invoking `ginkgo run`
+ from the step command script.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| documentation: |- | |
| Runs OpenShift Pipelines e2e tests using the Ginkgo-based | |
| release-tests-ginkgo test suite (tests/...) via scripts/run-tests.sh. | |
| documentation: |- | |
| Runs OpenShift Pipelines e2e tests using the Ginkgo-based | |
| release-tests-ginkgo test suite (tests/...) by invoking `ginkgo run` | |
| from the step command script. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/openshift-pipelines/ginkgo-tests/openshift-pipelines-ginkgo-tests-ref.yaml`
around lines 21 - 23, Update the documentation block so it accurately reflects
the actual entrypoint: replace the reference to "scripts/run-tests.sh" with a
note that the release-tests-ginkgo suite is invoked directly with "ginkgo run"
(as used by the paired commands file) and mention any relevant flags or test
path pattern (e.g., running tests/... via ginkgo run) so readers are directed to
the correct invocation point rather than the nonexistent script.
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "path": "openshift-pipelines/ginkgo-install/openshift-pipelines-ginkgo-install-ref.yaml", | |||
| "owners": { | |||
There was a problem hiding this comment.
use owner file in repo to sync the reviewers
There was a problem hiding this comment.
Aligned now. Should we add a few additional members?
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
…sts-ginkgo Signed-off-by: Anitha Natarajan <anataraj@redhat.com>
anithapriyanatarajan
force-pushed
the
ci-pipelines-release-test
branch
from
be99504 to
8207f12
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/test check-gh-automation |
1 similar comment
|
/test check-gh-automation |
|
/retest |
|
/pj-rehearse periodic-ci-openshift-pipelines-release-tests-ginkgo-main-openshift-pipelines-ocp4.21-e2e-osp-openshift-pipelines-e2e-osp |
|
@anithapriyanatarajan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-pipelines-release-tests-ginkgo-main-openshift-pipelines-ocp4.21-e2e-osp-openshift-pipelines-e2e-osp |
|
@anithapriyanatarajan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-pipelines-release-tests-ginkgo-main-openshift-pipelines-ocp4.21-e2e-osp-openshift-pipelines-e2e-osp |
|
@anithapriyanatarajan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@anithapriyanatarajan: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Add initial CI setup for the Ginkgo-based e2e test repo targeting OCP 4.21 on the aws-osp-qe cluster profile (psi.ospqa.com).
Changes:
Co-authored-by: Co-Pilot(Claude Sonnet 4.6)
Summary by CodeRabbit
This PR adds OpenShift CI configuration and reusable step-registry components to enable automated builds and scheduled e2e runs for the openshift-pipelines/release-tests-ginkgo repository (a Ginkgo-based e2e test suite).
What this changes in practice
CI operator config for release-tests-ginkgo (OCP 4.21):
Two reusable step-registry steps to run the suite:
Ownership and Prow/plugin config
Overall impact