Skip to content

OCPBUGS-77519: remove 4.20 oVirt storage jobs and references#79865

Open
rhrmo wants to merge 1 commit into
openshift:mainfrom
rhrmo:remove-ovirt-4.20
Open

OCPBUGS-77519: remove 4.20 oVirt storage jobs and references#79865
rhrmo wants to merge 1 commit into
openshift:mainfrom
rhrmo:remove-ovirt-4.20

Conversation

@rhrmo
Copy link
Copy Markdown
Contributor

@rhrmo rhrmo commented May 29, 2026

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhrmo: This pull request references Jira Issue OCPBUGS-77519, which is invalid:

  • expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.20" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhrmo
Copy link
Copy Markdown
Contributor Author

rhrmo commented May 29, 2026

/hold wait for openshift/cluster-storage-operator#704 to merge first

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d1e8447b-3aee-4293-b53e-ac63e4987f65

📥 Commits

Reviewing files that changed from the base of the PR and between 6043438 and 26acf71.

⛔ Files ignored due to path filters (4)
  • ci-operator/jobs/openshift/ovirt-csi-driver-operator/openshift-ovirt-csi-driver-operator-release-4.20-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/ovirt-csi-driver-operator/openshift-ovirt-csi-driver-operator-release-4.20-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/ovirt-csi-driver/openshift-ovirt-csi-driver-release-4.20-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/ovirt-csi-driver/openshift-ovirt-csi-driver-release-4.20-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/ovirt-csi-driver-operator/openshift-ovirt-csi-driver-operator-release-4.20.yaml
  • ci-operator/config/openshift/ovirt-csi-driver/openshift-ovirt-csi-driver-release-4.20.yaml
💤 Files with no reviewable changes (2)
  • ci-operator/config/openshift/ovirt-csi-driver/openshift-ovirt-csi-driver-release-4.20.yaml
  • ci-operator/config/openshift/ovirt-csi-driver-operator/openshift-ovirt-csi-driver-operator-release-4.20.yaml

Walkthrough

Two OpenShift CI/release configuration files for oVirt CSI components are deleted. The ovirt-csi-driver-operator and ovirt-csi-driver release 4.20 configurations are removed, eliminating build commands, image promotion targets, test job definitions, resource requests, and release metadata for the 4.20 stream.

Changes

Cohort / File(s) Summary
Removal of oVirt CSI 4.20 release configurations
ci-operator/config/openshift/ovirt-csi-driver-operator/openshift-ovirt-csi-driver-operator-release-4.20.yaml, ci-operator/config/openshift/ovirt-csi-driver/openshift-ovirt-csi-driver-release-4.20.yaml
Deletion of two CI/release configuration files (46 and 42 lines respectively). Removes build settings, Dockerfile configuration, image promotion to 4.20 stream, test job definitions, resource requests, and generated metadata for both the oVirt CSI driver operator and driver 4.20 releases.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error PR adds shell scripts that write OVIRT_ENGINE_PASSWORD (credentials) to YAML files without protection, exposing passwords in potential logs/output. Remove password variables from output files or implement masking in ipi-conf-ovirt-generate-ovirt-config-commands.sh and its insecure variant.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing 4.20 oVirt storage jobs and references. It directly matches the changeset which deletes two OpenShift release configuration files for oVirt CSI driver components targeting the 4.20 release.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies YAML CI configuration files; no Ginkgo test code is present in the openshift/release repository.
Test Structure And Quality ✅ Passed PR only modifies OpenShift CI configuration YAML files (removing oVirt 4.20 configs); contains no Ginkgo test code to review, making the check inapplicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR—only CI configuration and step registry files for oVirt storage jobs are modified.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR does not add any new Ginkgo e2e tests; it only contains YAML configuration files and CI operator setup files. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR removes CI configuration files for oVirt 4.20 release. No deployment manifests, operator code, or scheduling constraints are introduced or modified.
Ote Binary Stdout Contract ✅ Passed PR removes YAML CI configuration files only. OTE Binary Stdout Contract check applies to Go test source code, which is not modified in this PR.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR removes CI configuration files (YAML) for oVirt 4.20 releases, not Ginkgo e2e tests. Check applies only when new Ginkgo tests are added.
No-Weak-Crypto ✅ Passed PR removes 4.20 oVirt CI configuration files; no weak crypto patterns (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, or custom crypto) detected in YAML configs or related files.
Container-Privileges ✅ Passed PR removes oVirt 4.20 config files; no privileged containers, hostPID, hostNetwork, hostIPC, SYS_ADMIN capabilities, or allowPrivilegeEscalation settings found in YAML configurations.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bkhizgiy and dobsonj May 29, 2026 10:35
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhrmo
Once this PR has been reviewed and has the lgtm label, please assign eslutsky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rhrmo: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

@rhrmo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants