Skip to content

Protect finops-tools branches #79863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theute wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Protect finops-tools branches #79863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cf338b
Protect finops-tools branches
theute May 29, 2026
de635d2
Fix the ordering
theute May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions core-services/prow/02_config/openshift-online/finops-tools/_pluginconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
approve:
- repos:
- openshift-online/finops-tools
require_self_approval: false
external_plugins:
openshift-online/finops-tools:
- endpoint: http://refresh
events:
- issue_comment
name: refresh
- endpoint: http://needs-rebase
events:
- issue_comment
- pull_request
name: needs-rebase
lgtm:
- repos:
- openshift-online/finops-tools
review_acts_as_lgtm: true
plugins:
openshift-online/finops-tools:
plugins:
- assign
- blunderbuss
- cat
- dog
- heart
- golint
- goose
- help
- hold
- label
- lgtm
- lifecycle
- override
- pony
- retitle
- shrug
- sigmention
- skip
- trigger
- verify-owners
- owners-label
- wip
- yuks
- approve
triggers:
- org_invite:
prominent: {}
repos:
- openshift-online/finops-tools
trusted_apps:
- openshift-merge-bot
Comment on lines +47 to +53
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

org_invite is not a recognized field of the trigger plugin config.

The Prow trigger plugin's Trigger struct only accepts repos, trusted_apps, trusted_org, join_org_url, only_org_members, ignore_ok_to_test, and trigger_github_workflows. org_invite: prominent: {} is not part of this schema, so strict config validation (checkconfig) may reject this entry. trusted_apps/repos here are valid; please confirm whether org_invite is intended/supported, and drop it if not.

🔍 Proposed fix if `org_invite` is not supported 
 triggers:
-- org_invite:
-    prominent: {}
-  repos:
+- repos:
   - openshift-online/finops-tools
   trusted_apps:
   - openshift-merge-bot

Check whether org_invite is used by any other Prow plugin config in this repo (broad usage would suggest a recognized/forked field, none would corroborate a typo/misplacement):

#!/bin/bash
# Look for other `org_invite` usages across Prow plugin configs
rg -nP -C3 'org_invite' --iglob '**/_pluginconfig.yaml'
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@core-services/prow/02_config/openshift-online/finops-tools/_pluginconfig.yaml`
around lines 47 - 53, The triggers block contains an unsupported field
"org_invite: prominent: {}" which will fail strict Prow config validation;
remove the "org_invite: prominent: {}" entry from the triggers stanza (leave
valid keys like repos and trusted_apps unchanged) or, if this was intended for a
different plugin, move its configuration into the correct plugin's _pluginconfig
(search for usages of "org_invite" to confirm intent). Target the triggers block
surrounding the "triggers", "org_invite: prominent", "repos: -
openshift-online/finops-tools", and "trusted_apps: - openshift-merge-bot"
symbols when making the change.

Copy link
Copy Markdown
Contributor

@danilo-gemoli danilo-gemoli Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theute could you check and see whether this is the case or not?

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

33 changes: 33 additions & 0 deletions core-services/prow/02_config/openshift-online/finops-tools/_prowconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
branch-protection:
orgs:
openshift-online:
repos:
finops-tools:
branches:
main:
enforce_admins: true
protect: true
required_pull_request_reviews:
dismiss_stale_reviews: true
required_approving_review_count: 1
restrictions:
teams:
- openshift-bots
tide:
merge_method:
openshift-online/finops-tools: squash
queries:
- includedBranches:
- main
labels:
- approved
- lgtm
missingLabels:
- backports/unvalidated-commits
- do-not-merge/hold
- do-not-merge/invalid-owners-file
- do-not-merge/work-in-progress
- jira/invalid-bug
- needs-rebase
repos:
- openshift-online/finops-tools