Skip to content

Increase pagerduty-operator lint memory limit to 6Gi#79850

Open
clcollins wants to merge 1 commit into
openshift:mainfrom
clcollins:pdo-lint-memory-6gi
Open

Increase pagerduty-operator lint memory limit to 6Gi#79850
clcollins wants to merge 1 commit into
openshift:mainfrom
clcollins:pdo-lint-memory-6gi

Conversation

@clcollins
Copy link
Copy Markdown
Member

@clcollins clcollins commented May 29, 2026

Summary

  • Bump lint step memory limit from 4Gi to 6Gi for pagerduty-operator
  • golangci-lint OOMs during FIPS/boringcrypto builds after recent dependency updates expanded the module graph
  • Container is killed before linting completes — exit code 137 (OOMKilled)
  • All other steps (test, coverage, validate) remain at 4Gi default

Evidence

Test plan

🤖 Generated with Claude Code

Summary by CodeRabbit

This PR increases the memory limit for the pagerduty-operator's lint job in the OpenShift CI configuration from the default 4Gi to 6Gi. The change addresses recurring out-of-memory failures in the golangci-lint step during FIPS/boringcrypto builds, which were caused by expanded dependencies in the module graph following recent updates.

What changed:

  • Modified ci-operator/config/openshift/pagerduty-operator/openshift-pagerduty-operator-master.yaml to add explicit resource limits for the lint job (memory: 6Gi), overriding the default 4Gi limit set for all other jobs ('*'). Request values remain unchanged at cpu: 100m and memory: 200Mi.

Impact:
This is a targeted infrastructure change that enables the pagerduty-operator CI pipeline to complete successfully, preventing the lint container from being OOMKilled before validation completes.

golangci-lint OOMs at 4Gi with FIPS/boringcrypto builds after recent
dependency updates expanded the module graph. Failed 3 consecutive
times on PR openshift#434 with exit code 137 (OOMKilled).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ae22fdea-b2d3-4093-82d4-266371a27ad8

📥 Commits

Reviewing files that changed from the base of the PR and between 9a2d67f and afe5e95.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/pagerduty-operator/openshift-pagerduty-operator-master.yaml

Walkthrough

This PR updates the OpenShift CI configuration for the PagerDuty operator to add resource limits for the lint job. The change defines a 6Gi memory limit and 100m CPU and 200Mi memory requests under the global resource wildcard settings.

Changes

Lint Job Resource Limits

Layer / File(s) Summary
Lint job resource limits configuration
ci-operator/config/openshift/pagerduty-operator/openshift-pagerduty-operator-master.yaml
Adds memory resource limits (limits.memory: 6Gi) and request values (requests.cpu: 100m, requests.memory: 200Mi) for the lint job under resources: '*'.

Possibly Related PRs

  • openshift/release#79755: Also updates CI job resource memory sizing for resources: '*' entries with 6Gi memory limits, following the same configuration pattern.

Suggested Labels

lgtm, approved, rehearsals-ack

Suggested Reviewers

  • janboll
  • deads2k

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: increasing the pagerduty-operator lint job memory limit to 6Gi, which is the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies OpenShift CI configuration YAML files (adding memory limits to a lint job), not test code. No Ginkgo test definitions are present in the changes.
Test Structure And Quality ✅ Passed The PR only modifies CI configuration (resource limits for pagerduty-operator lint job) and contains no Ginkgo test code. The custom check is not applicable to this PR.
Microshift Test Compatibility ✅ Passed PR only modifies CI configuration (lint memory limit); no new Ginkgo e2e tests are added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only a CI configuration file to increase lint job memory limits; no Ginkgo e2e tests are added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI configuration for pagerduty-operator's lint job resource limits. No deployment manifests, operator code, or scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI configuration YAML (memory limit increase) with no application source code changes; OTE Binary Stdout Contract check is not applicable to infrastructure-only changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies CI configuration to increase memory limits for the pagerduty-operator lint job; no new Ginkgo e2e tests are added. The check does not apply.
No-Weak-Crypto ✅ Passed PR only modifies CI/CD configuration (memory limits for lint job), which is unrelated to cryptographic operations checked by no-weak-crypto rule.
Container-Privileges ✅ Passed PR only modifies resource limits (memory: 4Gi→6Gi); no privileged, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation, or runAsRoot settings present.
No-Sensitive-Data-In-Logs ✅ Passed PR adds only resource limit configuration (memory: 6Gi) for lint job; no sensitive data (passwords, tokens, API keys, PII) in the changed lines.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2026
@openshift-ci openshift-ci Bot requested review from nephomaniac and tnierman May 29, 2026 00:31
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@clcollins: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-pagerduty-operator-master-coverage openshift/pagerduty-operator presubmit Ci-operator config changed
pull-ci-openshift-pagerduty-operator-master-images openshift/pagerduty-operator presubmit Ci-operator config changed
pull-ci-openshift-pagerduty-operator-master-lint openshift/pagerduty-operator presubmit Ci-operator config changed
pull-ci-openshift-pagerduty-operator-master-test openshift/pagerduty-operator presubmit Ci-operator config changed
pull-ci-openshift-pagerduty-operator-master-validate openshift/pagerduty-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

@clcollins: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nephomaniac
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, nephomaniac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants