OPRUN-4569: test: remove OLMv1 OTE exceptions; scope OLMv0 exceptions to SNO#31172
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@tmshort: This pull request references OPRUN-4569 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughRemoves an olm exception in state-transition tests and updates progressing-state tests to detect control-plane topology, using an isSingleNode flag to restrict progressing exceptions for olm and operator-lifecycle-manager-packageserver to single-node clusters. ChangesOperator test exception scoping
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/payload-aggregate aggregated-aws-ovn-single-node-upgrade-5.0-micro 10 |
|
@tmshort: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/test e2e-aws-ovn-single-node |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-aws-upgrade-ovn-single-node 10 |
|
@tmshort: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/804bfe50-4ee4-11f1-9c63-4ffc4aa22055-0 |
|
/test e2e-aws-ovn-single-node |
|
Scheduling required tests: |
|
/payload-aggregate periodic-ci-openshift-release-master-aggregated-aws-ovn-single-node-upgrade-5.0-micro 5 |
|
@tmshort: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-aggregate periodic-ci-openshift-release-main-aws-ovn-single-node-upgrade-5.0-micro 5 |
|
@tmshort: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/test e2e-gcp-csi |
|
/test e2e-metal-ipi-ovn-ipv6 |
These tests passed! |
|
/test e2e-gcp-csi |
|
Job Failure Risk Analysis for sha: ddb8197
|
|
/test e2e-gcp-csi |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-aws-upgrade-ovn-single-node 10 |
… to SNO The OLMv1 fixes in cluster-olm-operator are now in release-5.0: - PR openshift#202: 2 replicas + PDB on HA topology prevents Available=False and spurious Progressing=True during rolling updates (OCPBUGS-62517, OCPBUGS-62635) Remove the OCPBUGS-62517 exception for olm Available=False entirely. The testUpgradeOperatorStateTransitions function already has a blanket SNO exemption, so single-node is covered. For the Progressing-related exceptions, add clientConfig to testUpgradeOperatorProgressingStateTransitions so it can detect topology, then scope both remaining exceptions to SNO only: - OCPBUGS-62635: olm Progressing=True during MCO window. On HA the 2-replica PDB fix prevents this; on SNO there is still 1 replica and the node reboot restarts all pods simultaneously. This had been removed, but is now restored since the issue still occurs under SNO. - OCPBUGS-63672: operator-lifecycle-manager-packageserver Progressing=True on empty reason. On HA, isAPIServiceBackendDisrupted() detects terminating pods and returns RetryableError. On SNO the OS-level reboot kills all pods at once so no terminating pod is observed and the detection does not fire. The operator-lifecycle-manager exception (OCPBUGS-65583) is intentionally kept; OLMv0 is in maintenance mode. Assisted-by: claude Signed-off-by: Todd Short <todd.short@me.com>
|
@tmshort: This pull request references OPRUN-4569 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-aws-upgrade-ovn-single-node 10 |
|
@tmshort: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/175c74f0-5453-11f1-817d-5d5b6fe83209-0 |
| case "olm": | ||
| // CatalogdDeploymentCatalogdControllerManager_Deploying | ||
| // OperatorcontrollerDeploymentOperatorControllerControllerManager_Deploying | ||
| // On HA, cluster-olm-operator PR #202 (2 replicas + PDB) prevents this. | ||
| // On SNO there is only one replica and the node reboot restarts all pods simultaneously. | ||
| if strings.HasSuffix(reason, "ControllerManager_Deploying") && isSingleNode { | ||
| return "https://issues.redhat.com/browse/OCPBUGS-62635" | ||
| } |
There was a problem hiding this comment.
#31112 removed this OLM exceptions, which needs to remain due to SNO. So, this restores it.
|
Scheduling required tests: |
|
/label qe-approved |
|
@bandrade: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jogeo, oceanc80, pedjak, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-vsphere-ovn-upi |
|
@tmshort: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
1 similar comment
|
@tmshort: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-aws-upgrade-ovn-single-node 5 |
|
@tmshort: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a3617a10-5474-11f1-8510-07ccf8d8c128-0 |
|
This recent |
These tests passed. |
The OLMv1 fixes in cluster-olm-operator are now in release-5.0:
Remove the OCPBUGS-62517 exception for olm Available=False entirely. The testUpgradeOperatorStateTransitions function already has a blanket SNO exemption, so single-node is covered.
For the Progressing-related exceptions, add clientConfig to testUpgradeOperatorProgressingStateTransitions so it can detect topology, then scope both remaining exceptions to SNO only:
The operator-lifecycle-manager exception (OCPBUGS-65583) is intentionally kept; OLMv0 is in maintenance mode.
Assisted-by: claude
Summary by CodeRabbit