NO-JIRA: upkeep: add exception for expected disruption during tnf upgrade

[eggfoobar]

Summary by CodeRabbit

Release Notes

• Tests
  • Enhanced validation of cluster operator behavior during upgrades on two-node and dual-replica configurations to ensure improved reliability.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@eggfoobar: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9919b0e7-e2b3-408a-8374-c88b25828c0d

📥 Commits

Reviewing files that changed from the base of the PR and between 00c4cba and 91e3816.

📒 Files selected for processing (1)

• pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

---

Walkthrough

This PR expands operator exception handling in cluster version operator upgrade tests to accommodate two-node topology scenarios. The authentication operator gains exceptions for pod unavailability during dual-replica upgrades and broader pod-update conditions during progressing state transitions. A new exception for openshift-controller-manager allows temporary unavailability on two-node clusters during disruptive upgrades.

Changes

Operator exception handling for two-node upgrade scenarios

Layer / File(s)	Summary
Authentication operator exception enhancements pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go	Adds a two-node exception for authentication that treats Degraded=True as acceptable when the condition reason is OAuthServerDeployment_UnavailablePod. Expands the Progressing-state exception to accept both APIServerDeployment_NewGeneration and APIServerDeployment_PodsUpdating reasons while machine-config is progressing, instead of only the former.
OpenShift controller manager exception for two-node topologies pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go	Introduces a new exception for openshift-controller-manager allowing Available=False with reason _NoPodsAvailable on two-node topologies during disruptive upgrades.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• openshift/origin#31172: Modifies the same operator exception logic in testUpgradeOperatorStateTransitions and related functions, broadening condition reason handling for topology-specific upgrade scenarios.

Suggested labels

ready-for-human-review

Suggested reviewers

• p0lyn0mial
• sjenning

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding an exception for expected disruption during TNF upgrade. It aligns with the file modifications that extend operator exception logic.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Test names use only static values: hardcoded operator names, condition types, and deterministic bugzilla mappings. PR only modifies exception logic, not test names.
Test Structure And Quality	✅ Passed	Tests use table-driven patterns with t.Run() subtests, meaningful testify assertions, clear test names, and follow codebase conventions. No cluster ops or setup/cleanup needed.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests (It, Describe, Context, When) are added in this PR. The changes only modify monitoring analysis functions for analyzing existing ClusterOperator events during upgrades.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR; only exception cases are added to existing monitor test functions for dual-replica topology upgrades.
Topology-Aware Scheduling Compatibility	✅ Passed	File is a monitoring test exception framework, not deployment/operator code. Changes add topology-aware exceptions for two-node upgrades without introducing scheduling constraints or affinity rules.
Ote Binary Stdout Contract	✅ Passed	File is a test utility package with no process-level functions, no stdout writes, and changes only add test exception logic without any output statements.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies monitor test utilities (not Ginkgo e2e tests) that generate JUnit results. No new Ginkgo test declarations (It/Describe/Context) are added.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eggfoobar
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eggfoobar]

/payload-aggregate periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade 3

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dc110630-54d0-11f1-84bc-8d42ca501ac9-0

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[eggfoobar]

/payload-aggregate periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade 3

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5070a4f0-5520-11f1-8df3-e785641a003c-0

[eggfoobar]

/payload-aggregate periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade 3

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/09cb9b50-554c-11f1-981e-6eb82a64fec3-0

[eggfoobar]

/verified by CI

The aggregated jobs show success for the monitor tests and all jobs passed

[openshift-ci-robot]

@eggfoobar: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

The aggregated jobs show success for the monitor tests and all jobs passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.