OCPBUGS-85513: Fix for Flaky OCP E2E failure Object count check the quota after import-image with --all option

[YamunadeviShanmugam]

The refactored test eliminates external dependencies by creating a local, multi-tag source ImageStream using the cluster's native CLI payload.

Testing with Fix:

 STEP: waiting for an is importer to import a tag gamma into a stream rq-local-multi-src @ 05/13/26 13:00:09.82
    STEP: checking quota after creating one local ImageStream with multiple tags @ 05/13/26 13:00:09.853
    STEP: importing all tags from the local repository into one new ImageStream (bulk import adds exactly one ImageStream) @ 05/13/26 13:00:09.917
  imagestream.image.openshift.io/rq-bulk-import-is imported

  Name:			rq-bulk-import-is
  Namespace:		e2e-test-object-count-rq-kktpk
  Created:		Less than a second ago
  Labels:			<none>
  Annotations:		openshift.io/image.dockerRepositoryCheck=2026-05-13T07:30:10Z
  Image Repository:	image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-bulk-import-is
  Image Lookup:		local=false
  Unique Images:		1
  Tags:			3

  alpha
    tagged from image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src:alpha

    * image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src@sha256:0ed7514f6b08a4d06cdeb463f1bd16b827ec482a706bc03ecc709f8fede4ea8d
        Less than a second ago

  beta
    tagged from image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src:beta

    * image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src@sha256:0ed7514f6b08a4d06cdeb463f1bd16b827ec482a706bc03ecc709f8fede4ea8d
        Less than a second ago

  gamma
    tagged from image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src:gamma

    * image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src@sha256:0ed7514f6b08a4d06cdeb463f1bd16b827ec482a706bc03ecc709f8fede4ea8d
        Less than a second ago

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@YamunadeviShanmugam: This pull request references Jira Issue OCPBUGS-85513, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The refactored test eliminates external dependencies by creating a local, multi-tag source ImageStream using the cluster's native CLI payload.

Testing with Fix:
STEP: waiting for an is importer to import a tag gamma into a stream rq-local-multi-src @ 05/13/26 13:00:09.82
STEP: checking quota after creating one local ImageStream with multiple tags @ 05/13/26 13:00:09.853
STEP: importing all tags from the local repository into one new ImageStream (bulk import adds exactly one ImageStream) @ 05/13/26 13:00:09.917
imagestream.image.openshift.io/rq-bulk-import-is imported

Name: rq-bulk-import-is
Namespace: e2e-test-object-count-rq-kktpk
Created: Less than a second ago
Labels:
Annotations: openshift.io/image.dockerRepositoryCheck=2026-05-13T07:30:10Z
Image Repository: image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-bulk-import-is
Image Lookup: local=false
Unique Images: 1
Tags: 3

alpha
tagged from image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src:alpha

• image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src@sha256:0ed7514f6b08a4d06cdeb463f1bd16b827ec482a706bc03ecc709f8fede4ea8d
  Less than a second ago

beta
tagged from image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src:beta

• image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src@sha256:0ed7514f6b08a4d06cdeb463f1bd16b827ec482a706bc03ecc709f8fede4ea8d
  Less than a second ago

gamma
tagged from image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src:gamma

• image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src@sha256:0ed7514f6b08a4d06cdeb463f1bd16b827ec482a706bc03ecc709f8fede4ea8d
  Less than a second ago

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

This PR enables a previously-skipped ResourceQuota test for bulk image imports by adding a helper function for integrated registry references and reimplementing the test flow to perform a bulk import, poll for completion, validate quota increases, and update expected imagestream counts.

Changes

ResourceQuota Bulk Import Test

Layer / File(s)	Summary
Helper for integrated registry import references test/extended/quota/resourcequota.go (lines 22–25)	Adds integratedRegistryImportFrom(registryHost, namespace, imageStream) utility to format the integrated-registry reference for import-image --from operations.
Test unskip and bulk import flow test/extended/quota/resourcequota.go (lines 172–173, 202–279)	Removes [Skipped:Disconnected] marker and replaces test logic: waits for integrated registry hostname, creates a multi-tag source ImageStream, performs admin bulk import with --all=true, polls until imported tags populate, and validates initial ResourceQuota usage.
Updated quota expectations test/extended/quota/resourcequota.go (line 288)	Increases expected openshift.io/imagestreams count from 2 to 3 after the additional tagging operation in the test.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 9 | ❌ 3

❌ Failed checks (3 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Structure And Quality	⚠️ Warning	13 of 14 assertions lack meaningful failure messages. Only line 260-261 includes a diagnostic message. This violates requirement #4 (assertion messages should help diagnose failures).	Add meaningful failure messages to all assertions. Example: o.Expect(err).NotTo(o.HaveOccurred(), "failed to wait for registry hostname"). This improves test failure diagnosis.
Microshift Test Compatibility	⚠️ Warning	Test uses image.openshift.io/v1 ImageStream API unavailable on MicroShift. No protective markers ([Skipped:MicroShift] or [apigroup:image.openshift.io]) are present.	Add [apigroup:image.openshift.io] tag to test name: g.It("check the quota after import-image with --all option [apigroup:image.openshift.io]", func() {

✅ Passed checks (9 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: fixing a flaky E2E test for the 'check the quota after import-image with --all option' scenario by removing external dependencies and refactoring it to use local resources.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test names are stable and deterministic. No dynamic values (generated suffixes, timestamps, UUIDs, node names, namespace names, or IP addresses) present in test titles.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Test uses only OpenShift APIs (ResourceQuota, ImageStream, image imports) available on SNO. No pod scheduling, node affinity, multi-node failover, or topology-dependent operations are present.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only e2e test file with ResourceQuota validation. No deployment manifests, controllers, or scheduling constraints present.
Ote Binary Stdout Contract	✅ Passed	File resourcequota.go complies with OTE Binary Stdout Contract. No process-level stdout writes detected. All test logic in g.It() blocks. New helper function is safe.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Test uses internal cluster resources (openshift/cli payload, internal registry via DNS). No hardcoded IPv4 addresses, external URLs, or external connectivity requirements detected.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[YamunadeviShanmugam]

/jira refresh

[openshift-ci-robot]

@YamunadeviShanmugam: This pull request references Jira Issue OCPBUGS-85513, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@YamunadeviShanmugam: This pull request references Jira Issue OCPBUGS-85513, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

The refactored test eliminates external dependencies by creating a local, multi-tag source ImageStream using the cluster's native CLI payload.

Testing with Fix:
STEP: waiting for an is importer to import a tag gamma into a stream rq-local-multi-src @ 05/13/26 13:00:09.82
STEP: checking quota after creating one local ImageStream with multiple tags @ 05/13/26 13:00:09.853
STEP: importing all tags from the local repository into one new ImageStream (bulk import adds exactly one ImageStream) @ 05/13/26 13:00:09.917
imagestream.image.openshift.io/rq-bulk-import-is imported

Name: rq-bulk-import-is
Namespace: e2e-test-object-count-rq-kktpk
Created: Less than a second ago
Labels:
Annotations: openshift.io/image.dockerRepositoryCheck=2026-05-13T07:30:10Z
Image Repository: image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-bulk-import-is
Image Lookup: local=false
Unique Images: 1
Tags: 3

alpha
tagged from image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src:alpha

• image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src@sha256:0ed7514f6b08a4d06cdeb463f1bd16b827ec482a706bc03ecc709f8fede4ea8d
  Less than a second ago

beta
tagged from image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src:beta

• image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src@sha256:0ed7514f6b08a4d06cdeb463f1bd16b827ec482a706bc03ecc709f8fede4ea8d
  Less than a second ago

gamma
tagged from image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src:gamma

• image-registry.openshift-image-registry.svc:5000/e2e-test-object-count-rq-kktpk/rq-local-multi-src@sha256:0ed7514f6b08a4d06cdeb463f1bd16b827ec482a706bc03ecc709f8fede4ea8d
  Less than a second ago

Summary by CodeRabbit

• Tests
• Re-enabled previously skipped resource quota tests for integrated registry image imports
• Enhanced test coverage for quota validation after bulk import operations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[sosiouxme]

/approve

[YamunadeviShanmugam]

/retest

[mgencur]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, sosiouxme, YamunadeviShanmugam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sosiouxme]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[YamunadeviShanmugam]

/retest-required

[YamunadeviShanmugam]

/retest-required

[YamunadeviShanmugam]

/retest

[YamunadeviShanmugam]

/retest-required

[openshift-trt]

Job Failure Risk Analysis for sha: a17d0ed

Job Name

Failure Risk

pull-ci-openshift-origin-main-e2e-vsphere-ovn

Medium [Monitor:legacy-cvo-invariants][bz-Insights Operator] clusteroperator/insights should not change condition/Degraded This test has passed 88.89% of 36 runs on release 5.0 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 OS:rhcos9 Owner:eng Platform:vsphere Procedure:none SecurityMode:default Topology:ha Upgrade:none] in the last week. --- [Monitor:legacy-cvo-invariants][bz-Insights Operator] clusteroperator/insights should not change condition/Available This test has passed 88.89% of 36 runs on release 5.0 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 OS:rhcos9 Owner:eng Platform:vsphere Procedure:none SecurityMode:default Topology:ha Upgrade:none] in the last week.

[YamunadeviShanmugam]

/retest

[YamunadeviShanmugam]

/retest

[YamunadeviShanmugam]

/retest

[openshift-ci]

@YamunadeviShanmugam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-microshift	a17d0ed	link	true	/test e2e-aws-ovn-microshift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.