OSDOCS-19483] Addresses comment made for OSDOCS 19483#111695
Conversation
openshift-ci
Bot
added
the
size/XS
|
🤖 Fri May 15 12:58:03 - Prow CI generated the docs preview: |
|
@stevsmit: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
SME approval: Ricardo Pchevuzinske Katz [8:48 AM] |
stevsmit
added
the
merge-review-needed
stevsmit
changed the title
stevsmit
added
the
do-not-merge
snarayan-redhat
added
merge-review-in-progress
| + | ||
| [NOTE] | ||
| ==== | ||
| The difference between highly available and non-highly-available topologies is the minimum number of replicas: at least two on highly available clusters, and one on clusters that do not use a highly available topology. Either topology can scale a gateway deployment out to ten replicas. |
There was a problem hiding this comment.
Suggestion: Using at least might be redundant since you have already specified minimum number.
This is nitty nit. So all good to merge. :)
There was a problem hiding this comment.
Thanks! Will definitely consider this after dev review! :)
snarayan-redhat
added
ok-to-merge
and removed
merge-review-in-progress
| + | ||
| [NOTE] | ||
| ==== | ||
| The difference between highly available and non-highly-available topologies is the minimum number of replicas: at least two on highly available clusters, and one on clusters that do not use a highly available topology. Either topology can scale a gateway deployment out to ten replicas. |
There was a problem hiding this comment.
Steve, if you mention either topology can scale to 10, then it will be not non ha (it will become redundant cluster). so better make similar to below.
The difference between high available and non-high-available topologies is the minimum number of replicas: at least two gateway instances on high available clusters(which can scale out to ten replicas), and only one gateway instance on the cluster that do not use a high available topology.
melvinjoseph86
left a comment
melvinjoseph86
left a comment
There was a problem hiding this comment.
Kindly make necessary changes
4 participants
Just looking for a review. Do not merge. I will merge this PR.
Version(s):
4.22+
Issue:
https://redhat.atlassian.net/browse/OSDOCS-19483
Link to docs preview:
https://111695--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ingress_load_balancing/configuring_ingress_cluster_traffic/ingress-gateway-api.html
QE review:
Additional information: