sitemap a11y improvements#5312
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
77a482e to
ea56f0e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
447b61b to
d853bbc
Compare
|
Work Done:
Notes:
|
d853bbc to
043cba5
Compare
|
rebased onto r-v1.9.x |
043cba5 to
b087979
Compare
|
@StephDriver passed this back as tests are failing here. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
...
ooh, that's interesting, because I was running a formatter with a pre-commit hook - which won't let me commit until it passes, so that means my formatter is out of sync with the one testing here. I'll have to dig into it more on Monday as to what and why. |
|
I haven't worked out why my existing hook wasn't firing for that file, when it fired for others - the most likely explanation is that it the difference crept in during a rebase. But the two missing empty lines have now been duly added. |
a714316 to
fe1b2ef
Compare
|
Unpicking the test failures.
Failures that are on the base branch too
I cannot reproduce the test errors from github locally. They seem to come down to |
8522ecf to
2033ddc
Compare
# Conflicts: # src/templates/common/site_map_index.xml # src/themes/clean/templates/elements/press_footer.html
closes #5170