Skip to content

fix: initialize uninitialized variables detected by Memory Sanitizer #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludomal wants to merge 3 commits into
base: STL2026_sv56_wavio
Choose a base branch
from
Open

fix: initialize uninitialized variables detected by Memory Sanitizer #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3be8508
fix(mnru): guard SHRT_MIN/SHRT_MAX with #ifndef (MSVC redefinition wa…
Jun 11, 2026
04d1df1
fix: resolve MSVC warnings in p50fbmnru.c and plcferio.c
Jun 11, 2026
6597031
docs: add Windows build instructions to README
Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ To build the STL tools, you need:

Not so recent C compilers might also work (not tested).

## Linux / macOS

```shell
#Download source code
git clone https://github.com/openitu/STL
Expand All @@ -26,16 +28,40 @@ git clone https://github.com/openitu/STL
cd STL

#Generate platform dependent build scripts using CMake
#For using a specific generator see CMake parameter "-G"
cmake .

##Build STL tools
#Build STL tools
cmake --build .

##Run tests (optional)
#Run tests (optional)
ctest
```

## Windows

Prerequisites:
* Visual Studio with the **"Desktop development with C++"** workload installed
* CMake (included with Visual Studio, or install separately)

```powershell
#Download source code
git clone https://github.com/openitu/STL

#Enter directory
cd STL

#Generate Visual Studio project files (adjust version as needed)
cmake -G "Visual Studio 18 2026" .

#Build STL tools
cmake --build . --config Release

#Run tests (optional)
ctest -C Release
```

> **Note:** On Windows, you must specify a configuration (`Release` or `Debug`) for both the build and test steps.

# Licenses
The STL, and all of its derivations, is subject to the "ITU-T General Public License", which is a modified version of the GPL1.
Please read the file `LICENSE.md` for the terms and conditions.
Expand Down
2 changes: 1 addition & 1 deletion src/eid/softbit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

/* ......... Smart prototypes .......... */
#ifndef ARGS
#if (defined(__STDC__) || defined(VMS) || defined(__DECC) || defined(MSDOS) || defined(__MSDOS__))
#if (defined(__STDC__) || defined(VMS) || defined(__DECC) || defined(MSDOS) || defined(__MSDOS__) || defined(_MSC_VER))
#define ARGS(x) x
#else
#define ARGS(x) ()
Expand Down
4 changes: 4 additions & 0 deletions src/mnru/p50fbmnru.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,12 @@
#define random_MNRU new_random_MNRU

/* Defines minimum and maximum value for a short int. */
#ifndef SHRT_MIN
#define SHRT_MIN -32768
#endif
#ifndef SHRT_MAX
#define SHRT_MAX +32767
#endif

void show_use(void)
{
Expand Down