chore(ci): use common workflows for undraft/verify tag - #182
Conversation
…lease) - Add a verify-version job that fails the tag build if the tag, manifest, build.gradle, and publish.gradle versions disagree -- catching the kind of drift that caused the 0.3.1/0.3.2 publish failure. - Replace the Roang-zero1 create-release job (which produced duplicate untagged-* drafts) with the shared openfga/.github undraft-release.yml reusable, which undrafts the tag-keyed release created by release-please after a successful publish. - Gate publish jobs on verify-version and add a top-level read permission. - Exclude CHANGELOG.md from spotless flexmark so the machine-generated changelog no longer fails formatting checks on release PRs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe workflow restricts default permissions, verifies release versions before publishing, and uses a pinned reusable workflow to undraft releases. Spotless Flexmark formatting now excludes ChangesCI and release workflow
Formatting configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Also excluded changelog from the spotlessFmt because autogenerated release-please default doesn't match it and needs whitespace changes with our pushes too |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s release CI to rely on shared OpenFGA GitHub workflows and to prevent version drift during tag builds, while also avoiding Spotless failures from the machine-generated changelog.
Changes:
- Added a
verify-versionjob for tag builds and gated publish jobs on it to catch version drift early. - Replaced the custom draft release creation job with the shared
openfga/.githubundraft-release.ymlreusable workflow. - Excluded
CHANGELOG.mdfrom Spotless Flexmark formatting.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build.gradle | Excludes CHANGELOG.md from Spotless Flexmark to prevent formatting failures on generated changelog updates. |
| .github/workflows/main.yaml | Adds a tag-only version verification gate, switches to a shared undraft workflow, and tightens default workflow permissions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit
CHANGELOG.md.