Ent 11150 unsubmitted courses fix#1115
Open
tpanda-sonata wants to merge 2 commits into
Open
Conversation
…MS discovery mechanism
pwnage101
reviewed
Dec 3, 2025
Comment on lines
-244
to
+247
| # to ensure active content is always returned | ||
| # to ensure active content is always ret |
Contributor
There was a problem hiding this comment.
This looks like an accidental deletion of text.
pwnage101
requested changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Rejected for now because I think is_active is too upstream and risky to change. 3rd part LMS integrations should use a customized implementation to avoid inadvertent modification of other content APIs.
More info here: https://2u-internal.atlassian.net/browse/ENT-11150?focusedCommentId=5762901
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the issue where unsubmitted / unpublished courses were being included
in the Enterprise Catalog report.
During catalog metadata generation, these courses should be excluded to prevent
incorrect content appearing in downstream systems.
What Was Changed
JIRA: ENT-11150