Skip to content

chore: append pr review instructions section to copilot-instructions.md#2653

Open
iloveagent57 wants to merge 1 commit into
masterfrom
chore/patch-copilot-instructions-2026-07-07
Open

chore: append pr review instructions section to copilot-instructions.md#2653
iloveagent57 wants to merge 1 commit into
masterfrom
chore/patch-copilot-instructions-2026-07-07

Conversation

@iloveagent57

Copy link
Copy Markdown
Contributor

Summary

Append the PR Review Instructions section (house rules, security, test coverage, and output format) from docs/templates/copilot-instructions.md.template in ai-devtools-internal.

Adds three sequential concern passes to .github/copilot-instructions.md:

  1. Architecture fit — four House Rules (reuse before reinvent, earn every guard, YAGNI/trust defaults, respect source of truth). Biased toward flagging excess and redundancy, not absence. Rules 1 & 4 require naming the existing symbol and path; no name, no finding.
  2. Security — auth/permissions, input validation, injection, PII annotations, CSRF. edx-drf-extensions/edx-rbac for backends; XSS/key exposure for frontends.
  3. Test coverage — untested new logic, implementation-detail assertions, missing edge cases, brittle snapshots.

Structured output format: HEADLINE, House-Rule Findings table with file:line evidence, Security & Tests list, HOTSPOTS, and MERGE_READINESS: READY | CHANGES_REQUIRED | REJECT_SCOPE.

File changed: .github/copilot-instructions.md

🤖 Generated by the cross-repo-patch skill.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @iloveagent57!

This repository is currently maintained by @openedx/2u-enterprise.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jul 7, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jul 7, 2026
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.65%. Comparing base (8ed796e) to head (d0cf723).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2653   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files         257      257           
  Lines       16954    16954           
  Branches     1677     1677           
=======================================
  Hits        14692    14692           
  Misses       1927     1927           
  Partials      335      335           
Flag Coverage Δ
unittests 86.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jul 8, 2026
@mphilbrick211 mphilbrick211 requested a review from a team July 8, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants