Skip to content

fix: prevent partial-promote state when checkpoint destination conflicts #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Berkkirik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent partial-promote state when checkpoint destination conflicts #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion opf/_common/checkpoint_download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,16 @@ def _promote_original_subtree(target: Path) -> None:
f"Downloaded checkpoint is missing expected subtree: {original_dir}"
)

for path in original_dir.iterdir():
entries = list(original_dir.iterdir())
for path in entries:
destination = target / path.name
if destination.exists():
raise RuntimeError(
"Cannot promote downloaded checkpoint file because destination "
f"already exists: {destination}"
)
for path in entries:
destination = target / path.name
shutil.move(str(path), str(destination))
original_dir.rmdir()

Expand Down