Skip to content

fix: iter_json_records raises IsADirectoryError on directory paths #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Berkkirik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: iter_json_records raises IsADirectoryError on directory paths #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opf/_eval/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def iter_json_records(dataset_path: str) -> Iterator[Mapping[str, object]]:
raise ValueError("Dataset path must be local filesystem only (no URI schemes).")
if "*" in dataset_path:
file_paths = sorted(glob.glob(dataset_path))
elif os.path.exists(dataset_path):
elif os.path.isfile(dataset_path):
file_paths = [dataset_path]
else:
file_paths = sorted(glob.glob(f"{dataset_path.rstrip('/')}/*.gz"))
Expand Down