chore(geneva): make certificate authentication opt-in - #3730
Merged
lalitb merged 5 commits intoAug 13, 2026
Conversation
lalitb
marked this pull request as ready for review
August 12, 2026 05:59
Pull request dashboard statusMerged · refreshed 2026-08-13 01:05 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes Geneva PKCS#12 certificate authentication opt-in across the Rust OTAP-Dataflow Geneva exporter, so default builds avoid pulling in PKCS#12 parsing/crypto dependencies and reject certificate configs early unless explicitly enabled.
Changes:
- Introduces a
geneva-certificate-authfeature and wires it through the workspace and contrib-nodes crate features. - Adds early config validation (and tests) to reject
auth.type: certificatewhen the opt-in feature is disabled. - Updates Geneva exporter docs and example pipeline YAMLs to default to managed identity authentication.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rust/otap-dataflow/crates/contrib-nodes/src/exporters/geneva_exporter/README.md | Documents the new opt-in certificate auth feature and clarifies supported auth modes in default builds. |
| rust/otap-dataflow/crates/contrib-nodes/src/exporters/geneva_exporter/otlp-geneva.yaml | Updates example to use managed identity instead of certificate auth by default. |
| rust/otap-dataflow/crates/contrib-nodes/src/exporters/geneva_exporter/otlp-geneva-set-table-name.yaml | Updates example auth config to managed identity. |
| rust/otap-dataflow/crates/contrib-nodes/src/exporters/geneva_exporter/otlp-geneva-set-routing-table-name.yaml | Updates example auth config to managed identity (multiple sections). |
| rust/otap-dataflow/crates/contrib-nodes/src/exporters/geneva_exporter/mod.rs | Adds validation and tests enforcing that certificate auth requires the opt-in feature. |
| rust/otap-dataflow/crates/contrib-nodes/Cargo.toml | Adds the geneva-certificate-auth feature and maps it to the upstream geneva-uploader feature. |
| rust/otap-dataflow/Cargo.toml | Bumps geneva-uploader git rev and adds a workspace-level geneva-certificate-auth feature. |
| rust/otap-dataflow/Cargo.lock | Updates lockfile to reflect the geneva-uploader rev bump and dependency graph changes. |
| rust/otap-dataflow/.chloggen/geneva-certificate-auth-opt-in.yaml | Adds a changelog entry describing the default behavior change and migration guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3730 +/- ##
==========================================
- Coverage 87.38% 87.37% -0.01%
==========================================
Files 841 841
Lines 339106 339131 +25
==========================================
+ Hits 296324 296326 +2
- Misses 42250 42273 +23
Partials 532 532
🚀 New features to boost your workflow:
|
lalitb
enabled auto-merge
August 12, 2026 20:37
utpilla
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
geneva-uploaderto the latest upstream commit.geneva-certificate-authfeature.Validation