fix: Limiting gem & tests to mri - #2429
Open
thompson-tomo wants to merge 12 commits into
Open
Conversation
thompson-tomo
requested review from
a team,
dazuma,
hannahramadan,
kaylareopelle,
robbkidd,
simi and
xuan-cao-swi
as code owners
July 3, 2026 17:24
github-actions
Bot
added
ci
instrumentation-grpc
instrumentation-gruf
instrumentation-lmdb
labels
kaylareopelle
left a comment
kaylareopelle
left a comment
Contributor
There was a problem hiding this comment.
A few questions/small changes. There's also a merge conflict.
Comment on lines
+139
to
+147
| run: | | ||
| files=$(ruby -e 'puts Dir["coverage/**/.resultset.json"]') | ||
|
|
||
| if [ -z "$files" ]; then | ||
| echo "No coverage files found; skipping coverage check for this runtime." | ||
| exit 0 | ||
| fi | ||
|
|
||
| bundle exec ruby -e 'require "simplecov"; SimpleCov.minimum_coverage(ENV["MINIMUM_COVERAGE"].to_i); SimpleCov.collate Dir["coverage/**/.resultset.json"];' |
Contributor
There was a problem hiding this comment.
Is this related to the JRuby changes? I'm fine keeping it in this PR, just want to make sure I'm not misunderstanding what it's doing.
Contributor
Author
There was a problem hiding this comment.
It was necessary to handle when jruby tests were skipped hence the step had no coverage files. Without it the ci errored.
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This limits the gems to only be used on mri as they require native c code & no java replacements are available as drop-in replacements.