Skip to content

Enabled flake8-tidy-import rule for ruff linter #5019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrmx merged 8 commits into from
Apr 3, 2026
Merged

Enabled flake8-tidy-import rule for ruff linter #5019

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
da0455e
Enabled flake8-tidy-import rule for ruff linter
JayeshHire Mar 29, 2026
1809b73
removed warning suppression comments and instead ignored the tests di…
JayeshHire Mar 30, 2026
8906ab8
added change related info in the CHANGELOG
JayeshHire Mar 30, 2026
d1d38df
Merge branch 'main' into TID-rule
emdneto Mar 31, 2026
af7883b
Merge branch 'main' into TID-rule
JayeshHire Mar 31, 2026
39036e5
Merge branch 'main' into TID-rule
JayeshHire Apr 2, 2026
66d195a
Update CHANGELOG.md
xrmx Apr 3, 2026
f802e5d
Merge branch 'main' into TID-rule
xrmx Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ select = [
"PLE", # pylint error
"Q", # flake8-quotes
"G", # https://docs.astral.sh/ruff/rules/#flake8-logging-format-g
"TID", # flake8-tidy-imports
]

ignore = [
Expand Down
6 changes: 3 additions & 3 deletions ...opentelemetry-opentracing-shim/tests/testbed/test_active_span_replacement/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
import asyncio

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import stop_loop_when
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import stop_loop_when # noqa: TID252


class TestAsyncio(OpenTelemetryTestCase):
Expand Down
4 changes: 2 additions & 2 deletions ...opentelemetry-opentracing-shim/tests/testbed/test_active_span_replacement/test_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
)

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252


class TestThreads(OpenTelemetryTestCase):
Expand Down
6 changes: 3 additions & 3 deletions shim/opentelemetry-opentracing-shim/tests/testbed/test_client_server/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
from opentracing.ext import tags

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import get_logger, get_one_by_tag, stop_loop_when
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import get_logger, get_one_by_tag, stop_loop_when # noqa: TID252

logger = get_logger(__name__)

Expand Down
6 changes: 3 additions & 3 deletions shim/opentelemetry-opentracing-shim/tests/testbed/test_client_server/test_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
from opentracing.ext import tags

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import await_until, get_logger, get_one_by_tag
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import await_until, get_logger, get_one_by_tag # noqa: TID252

logger = get_logger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion ...entelemetry-opentracing-shim/tests/testbed/test_common_request_handler/request_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from opentracing.ext import tags

# pylint: disable=import-error
from ..utils import get_logger
from ..utils import get_logger # noqa: TID252

logger = get_logger(__name__)

Expand Down
6 changes: 3 additions & 3 deletions .../opentelemetry-opentracing-shim/tests/testbed/test_common_request_handler/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
from opentracing.ext import tags

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import get_logger, get_one_by_operation_name, stop_loop_when
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import get_logger, get_one_by_operation_name, stop_loop_when # noqa: TID252
from .request_handler import RequestHandler

logger = get_logger(__name__)
Expand Down
6 changes: 3 additions & 3 deletions .../opentelemetry-opentracing-shim/tests/testbed/test_common_request_handler/test_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
from opentracing.ext import tags

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import get_logger, get_one_by_operation_name
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import get_logger, get_one_by_operation_name # noqa: TID252
from .request_handler import RequestHandler

logger = get_logger(__name__)
Expand Down
6 changes: 3 additions & 3 deletions shim/opentelemetry-opentracing-shim/tests/testbed/test_late_span_finish/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
import asyncio

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import get_logger, stop_loop_when
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import get_logger, stop_loop_when # noqa: TID252

logger = get_logger(__name__)

Expand Down
4 changes: 2 additions & 2 deletions shim/opentelemetry-opentracing-shim/tests/testbed/test_late_span_finish/test_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
)

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252


class TestThreads(OpenTelemetryTestCase):
Expand Down
6 changes: 3 additions & 3 deletions shim/opentelemetry-opentracing-shim/tests/testbed/test_listener_per_request/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
from opentracing.ext import tags

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import get_one_by_tag
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import get_one_by_tag # noqa: TID252
from .response_listener import ResponseListener


Expand Down
6 changes: 3 additions & 3 deletions shim/opentelemetry-opentracing-shim/tests/testbed/test_listener_per_request/test_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
from opentracing.ext import tags

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import get_one_by_tag
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import get_one_by_tag # noqa: TID252
from .response_listener import ResponseListener


Expand Down
6 changes: 3 additions & 3 deletions shim/opentelemetry-opentracing-shim/tests/testbed/test_multiple_callbacks/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
import random

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import get_logger, stop_loop_when
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import get_logger, stop_loop_when # noqa: TID252

random.seed()
logger = get_logger(__name__)
Expand Down
6 changes: 3 additions & 3 deletions shim/opentelemetry-opentracing-shim/tests/testbed/test_multiple_callbacks/test_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
)

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import RefCount, get_logger
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import RefCount, get_logger # noqa: TID252

random.seed()
logger = get_logger(__name__)
Expand Down
6 changes: 3 additions & 3 deletions shim/opentelemetry-opentracing-shim/tests/testbed/test_nested_callbacks/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
import asyncio

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import stop_loop_when
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import stop_loop_when # noqa: TID252


class TestAsyncio(OpenTelemetryTestCase):
Expand Down
6 changes: 3 additions & 3 deletions shim/opentelemetry-opentracing-shim/tests/testbed/test_nested_callbacks/test_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
)

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..utils import await_until
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252
from ..utils import await_until # noqa: TID252


class TestThreads(OpenTelemetryTestCase):
Expand Down
4 changes: 2 additions & 2 deletions ...pentelemetry-opentracing-shim/tests/testbed/test_subtask_span_propagation/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
import asyncio

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
from ..testcase import OpenTelemetryTestCase # noqa: TID252


class TestAsyncio(OpenTelemetryTestCase):
Expand Down
4 changes: 2 additions & 2 deletions ...pentelemetry-opentracing-shim/tests/testbed/test_subtask_span_propagation/test_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
)

# pylint: disable=import-error
from ..otel_ot_shim_tracer import MockTracer
from ..testcase import OpenTelemetryTestCase
from ..otel_ot_shim_tracer import MockTracer # noqa: TID252
Comment thread
JayeshHire marked this conversation as resolved.
Outdated
from ..testcase import OpenTelemetryTestCase # noqa: TID252


class TestThreads(OpenTelemetryTestCase):
Expand Down
Loading