Skip to content

fix(celery): coerce non-string values to str in CeleryGetter.get() #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alliasgher wants to merge 2 commits into from
+13 −2
Closed

fix(celery): coerce non-string values to str in CeleryGetter.get() #4434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9ee765
fix(celery): coerce non-string values to str in CeleryGetter.get()
alliasgher Apr 14, 2026
c433dd2
chore: add CHANGELOG entry for #4434
alliasgher Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Bump `pylint` to `4.0.5`
([#4244](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4244))

### Fixed

- `opentelemetry-instrumentation-celery`: Coerce non-string header values to `str` in `CeleryGetter.get()` so context propagation does not fail when downstream libraries set non-string headers
([#4434](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4434))

### Breaking changes

- Drop Python 3.9 support
Expand Down
10 changes: 8 additions & 2 deletions ...opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,14 @@ def get(self, carrier, key):
value = getattr(carrier, key, None)
if value is None:
return None
if isinstance(value, str) or not isinstance(value, Iterable):
value = (value,)
if isinstance(value, str):
return (value,)
if not isinstance(value, Iterable):
# Coerce non-string, non-iterable values (e.g. int from Celery
# task attributes like timelimit) to str so that propagators
# such as TraceContext don't crash with a TypeError when calling
# re.split() on the value.
return (str(value),)
return value

def keys(self, carrier):
Expand Down