Skip to content

fix(celery): coerce timelimit values to strings in span attributes #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DrMeers wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

fix(celery): coerce timelimit values to strings in span attributes #4361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26a551d
fix(celery): coerce timelimit values to strings in span attributes
DrMeers Mar 26, 2026
ebf6c4f
Add CHANGELOG entry for timelimit fix
DrMeers Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- `opentelemetry-instrumentation-celery`: Coerce timelimit values to strings in `set_attributes_from_context()` to prevent mixed-type span attribute warning
([#4361](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4361))
- `opentelemetry-docker-tests`: Replace deprecated `SpanAttributes` from `opentelemetry.semconv.trace` with `opentelemetry.semconv._incubating.attributes`
([#4339](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4339))
- `opentelemetry-instrumentation-confluent-kafka`: Skip `recv` span creation when `poll()` returns no message or `consume()` returns an empty list, avoiding empty spans on idle polls
Expand Down
2 changes: 1 addition & 1 deletion ...on/opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def set_attributes_from_context(span, context):
if value in [(None, None), [None, None]]:
continue
if None in value:
value = ["" if tl is None else tl for tl in value]
value = ["" if tl is None else str(tl) for tl in value]

# Skip `retries` if it's value is `0`
if key == "retries" and value == 0:
Expand Down
Loading