Skip to content

Support enable_commenter for instrument_connection (version 2)#4267

Open
tammy-baylis-swi wants to merge 25 commits intoopen-telemetry:mainfrom
tammy-baylis-swi:v2-enable-commenter-instrument-connection
Open

Support enable_commenter for instrument_connection (version 2)#4267
tammy-baylis-swi wants to merge 25 commits intoopen-telemetry:mainfrom
tammy-baylis-swi:v2-enable-commenter-instrument-connection

Conversation

@tammy-baylis-swi
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Feb 26, 2026

Description

Support enable_commenter for psycopg2/psycopg instrument_connection functions.

Fixes #3070

Depends on #4257 to fix instrument_connection in psycopg2 first. ✅

This replaces #3071. I've incorporated some feedback from that PR into this one.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • tox -e py312-test-instrumentation-psycopg2
  • tox -e py312-test-instrumentation-psycopg
  • Instrumented db client app that calls Psycopg2Instrumentor.instrument_connection
  • Instrumented db client app that calls PsycopgInstrumentor.instrument_connection

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review March 3, 2026 18:00
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner March 3, 2026 18:00
@tammy-baylis-swi tammy-baylis-swi moved this to Ready for review in Python PR digest Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

Add sqlcomment support for psycopg(2) instrument_connection

1 participant