Reduce severity & verbosity of instrumentation ImportError (#1115)#4064
Open
john-karp wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Reduce severity & verbosity of instrumentation ImportError (#1115)#4064john-karp wants to merge 2 commits intoopen-telemetry:mainfrom
john-karp wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
…metry#1115) In auto-instrumentation context, it is expected that many of the supported target libraries will not be present. Hence, it does not make sense to flood logs with ImportErrors for this expected scenario.
john-karp
force-pushed
the
reduce-excessive-import-errors
branch
from
1fd497e to
b236d15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In auto-instrumentation context, it is expected that many of the supported target libraries will not be present. Hence, it does not make sense to flood logs with ImportErrors for this expected scenario.
The existing workaround of having users set
OTEL_PYTHON_DISABLED_INSTRUMENTATIONSto prevent this gets in the way of the ideal of "making instrumentation easy", because instead of allowing for instrumentation to be 'automatic', users then have to come up with (and maintain in the face of upstream changes) an explicit list of instrumentations to opt out of.Fixes #1115
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
toxDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.