feat(nestjs): add instrumentation for NestJS microservice#3435
feat(nestjs): add instrumentation for NestJS microservice#3435neilime wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
4222aba to
e793cc5
Compare
cbd154c to
e27c710
Compare
e27c710 to
c9262de
Compare
c9262de to
6ec6182
Compare
6ec6182 to
0c99a46
Compare
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
3790533 to
0705e54
Compare
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
0705e54 to
b92e038
Compare
|
Hi @blumamir, @dyladan, @[legendecas, @pichlermarc, I will need you opinion on this PR. I'm convinced that having instrumentation for just nestjs-core it to restrictive. Having an instrumation by nestjs package is bloated. IMO the best solution is to deprecated the original nestjs-core instrumentation and forge a new nestjs (only) instrumentation. I have made the code, it's working good, battle tested and backward compatible. But I dont how to deal with de preciation and the new package. I've made what I supposed to be ok, but I'll appreciate your recommandation to mathc with repository practices. Thanks |
|
Hi @neilime Thanks for working on this. I'm okay with having a new and more generic instrumentation (let's wait for more feedback). IMHO I would split this PR into smaller ones with this order
If you agree with this process I think this PR should only contain the new instrumentation. And I'd prefer to not refactor the current instrumentation so we avoid maintenance on it. |
Which problem is this PR solving?
@opentelemetry/instrumentation-nestjs-core, so Nest microservice applications and hybrid apps do not produce dedicated spans for microservice bootstrapping or message/event handlers.Short description of the changes
@opentelemetry/instrumentation-nestjspackage that instruments both Nest HTTP controllers and Nest microservice handlers.NestFactory.createMicroserviceandapp.connectMicroservice) and for message/event handler execution.@opentelemetry/instrumentation-nestjs-coreas a deprecated compatibility wrapper that delegates to the new package with microservice instrumentation disabled.@opentelemetry/auto-instrumentations-nodeand update the related README/docs.