Skip to content

[OTLP EXPORTER] fix OTLP recordable attribute spec compliance#4166

Draft
dbarker wants to merge 3 commits into
open-telemetry:mainfrom
dbarker:fix_otlp_attribute_spec_compliance
Draft

[OTLP EXPORTER] fix OTLP recordable attribute spec compliance#4166
dbarker wants to merge 3 commits into
open-telemetry:mainfrom
dbarker:fix_otlp_attribute_spec_compliance

use unordered map to track otlp recordable attributes. check for null…

88e47f6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 22, 2026 in 1s

82.84% (+0.01%) compared to de26178

View this Pull Request on Codecov

82.84% (+0.01%) compared to de26178

Details

Codecov Report

❌ Patch coverage is 92.19858% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.84%. Comparing base (de26178) to head (88e47f6).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...xporters/otlp/src/otlp_populate_attribute_utils.cc 90.75% 10 Missing ⚠️
sdk/src/logs/multi_recordable.cc 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4166      +/-   ##
==========================================
+ Coverage   82.83%   82.84%   +0.01%     
==========================================
  Files         406      406              
  Lines       16913    16951      +38     
==========================================
+ Hits        14009    14041      +32     
- Misses       2904     2910       +6     
Files with missing lines Coverage Δ
...opentelemetry/exporters/otlp/otlp_log_recordable.h 100.00% <ø> (ø)
...ude/opentelemetry/exporters/otlp/otlp_recordable.h 100.00% <ø> (ø)
exporters/otlp/src/otlp_log_recordable.cc 40.13% <100.00%> (+4.08%) ⬆️
exporters/otlp/src/otlp_metric_utils.cc 92.03% <100.00%> (ø)
exporters/otlp/src/otlp_recordable.cc 91.06% <100.00%> (+0.80%) ⬆️
sdk/src/trace/span.cc 89.10% <100.00%> (+0.21%) ⬆️
sdk/src/logs/multi_recordable.cc 89.34% <50.00%> (-1.20%) ⬇️
...xporters/otlp/src/otlp_populate_attribute_utils.cc 91.72% <90.75%> (-1.23%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.