[extension/awslogsencoding, receiver/awsfirehose] Deprecate transparent gzip decompression#47744
Open
singhvibhanshu wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Conversation
Signed-off-by: singhvibhanshu <singhvibhanshu@hotmail.com>
github-actions
bot
added
receiver/awsfirehose
extension/encoding/awslogsencoding
labels
Contributor
Author
|
/rerun |
axw
reviewed
Apr 20, 2026
Contributor
axw
left a comment
axw
left a comment
There was a problem hiding this comment.
@singhvibhanshu thanks for the PR. Can you please split the Firehose receiver changes into a separate one?
Comment on lines
+89
to
+98
|
|
||
| id, err := encodingToComponentID(encoding) | ||
| if err != nil { | ||
| return fmt.Errorf("invalid encoding extension %q: %w", encoding, err) | ||
| } | ||
|
|
||
| componentType := id.Type() | ||
| if componentType == awsLogsEncodingType || componentType == awsLogsEncodingDeprecatedType { | ||
| c.decompressGzipRecord = true | ||
| } |
Contributor
There was a problem hiding this comment.
Let's not make this specific to one encoding extension. The receiver can be changed to always decompress gzip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46463