Skip to content

[receiver/httpcheck] record tls cert metric once per scrape#47741

Open
jeevan6996 wants to merge 2 commits intoopen-telemetry:mainfrom
jeevan6996:fix-httpcheck-tls-cert-duplicate-metric
Open

[receiver/httpcheck] record tls cert metric once per scrape#47741
jeevan6996 wants to merge 2 commits intoopen-telemetry:mainfrom
jeevan6996:fix-httpcheck-tls-cert-duplicate-metric

Conversation

@jeevan6996
Copy link
Copy Markdown

@jeevan6996 jeevan6996 commented Apr 18, 2026

Summary

  • remove the duplicated httpcheck.tls.cert_remaining recording block in scraper.go
  • keep a single TLS cert metric emission per endpoint scrape
  • tighten test coverage to assert exactly one data point is emitted in the HTTPS TLS metric test

Fixes #47740.

Testing

  • cd receiver/httpcheckreceiver && go test ./...

@jeevan6996 jeevan6996 requested a review from a team as a code owner April 18, 2026 10:44
@jeevan6996 jeevan6996 requested a review from mx-psi April 18, 2026 10:44
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 18, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions
Copy link
Copy Markdown
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@github-actions github-actions bot added first-time contributor PRs made by new contributors receiver/httpcheck HTTP Check receiver labels Apr 18, 2026
@github-actions github-actions bot requested a review from VenuEmmadi April 18, 2026 10:44
@paulojmdias
Copy link
Copy Markdown
Member

/workflow-approve

@paulojmdias
Copy link
Copy Markdown
Member

Please add a changelog entry for this change

Copy link
Copy Markdown
Contributor

@himanshu130700 himanshu130700 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time contributor PRs made by new contributors receiver/httpcheck HTTP Check receiver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[receiver/httpcheck] RecordHttpcheckTLSCertRemainingDataPoint is called twice per scrape causing duplicate metrics

4 participants