[receiver/nsxt] Enable re-aggregation feature#47738
Open
nicknikolakakis wants to merge 1 commit intoopen-telemetry:mainfrom
Open
[receiver/nsxt] Enable re-aggregation feature#47738nicknikolakakis wants to merge 1 commit intoopen-telemetry:mainfrom
nicknikolakakis wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Set reaggregation_enabled: true in metadata.yaml and mark all attributes (class, direction, disk_state, packet.type) as recommended. Removed unused slices import from generated code (upstream mdatagen template bug open-telemetry/opentelemetry-collector#15145). Fixes open-telemetry#46369 Part of open-telemetry#45396 Signed-off-by: Nick Nikolakakis <nonicked@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46369
Part of #45396
Summary
reaggregation_enabled: trueinmetadata.yamlrequirement_level: recommendedto all attributes (class,direction,disk_state,packet.type)go generate ./...,make gci, andmake chlog-validateto regenerate all derived filesslicesimport from generated code (upstream mdatagen template bug [cmd/mdatagen] only import "slices" when a required reagg attribute exists opentelemetry-collector#15145)Test plan
go test ./...inreceiver/nsxtreceiver/- all tests passmake chlog-validate- validmake gci- no diffsschemagen- schema up to date