[receiver/tlscheck] Enable re-aggregation feature#47736
Open
alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
Open
[receiver/tlscheck] Enable re-aggregation feature#47736alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Part of open-telemetry#45396. Sets reaggregation_enabled: true in metadata.yaml and assigns requirement levels to the three x.509 certificate attributes: - tlscheck.x509.cn: recommended (enabled by default, can be disabled) - tlscheck.x509.issuer: recommended (enabled by default, can be disabled) - tlscheck.x509.san: opt_in (disabled by default, can be enabled) Regenerated metadata files with mdatagen. Note: this change was generated with a patched mdatagen that fixes an unused "slices" import when reaggregation is enabled but no attribute carries requirement_level: required. The template fix is tracked in open-telemetry/opentelemetry-collector. Signed-off-by: Ali <alliasgher123@gmail.com>
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
- Use receiver/tls_check (the type name) not receiver/tlscheck as the chloggen component - Run gci to fix import grouping in generated_package_test.go and generated_config_test.go Signed-off-by: Ali <alliasgher123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #45396.
Summary
Sets
reaggregation_enabled: trueinmetadata.yamland assigns requirement levels to the three x.509 certificate attributes:tlscheck.x509.cnrecommendedtlscheck.x509.issuerrecommendedtlscheck.x509.sanopt_inThe
tlscheck.targetis already a resource attribute so no metric attribute needsrequiredlevel.Generated metadata files with mdatagen.
Note
When running
mdatagenwithrecommended/opt_inattributes but norequiredattribute, the generatedgenerated_config.goimports"slices"unconditionally but never calls anyslices.*function, causing a compile error. A fix has been submitted to the upstream mdatagen template: open-telemetry/opentelemetry-collector#15145. The files in this PR were generated with that fix applied.Testing
All existing
receiver/tlscheckreceivertests pass with the changes applied:```
ok github.com/open-telemetry/opentelemetry-collector-contrib/receiver/tlscheckreceiver
ok github.com/open-telemetry/opentelemetry-collector-contrib/receiver/tlscheckreceiver/internal/metadata
```