[cmd/opampsupervisor] feat: Add extensions framework to supervisor#47732
Draft
dpaasman00 wants to merge 2 commits intoopen-telemetry:mainfrom
Draft
[cmd/opampsupervisor] feat: Add extensions framework to supervisor#47732dpaasman00 wants to merge 2 commits intoopen-telemetry:mainfrom
dpaasman00 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
54b8ca2 to
435d2c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a framework to the supervisor that allows it to utilize extensions from the collector ecosystem.
opampsupervisor.Extensions, and will need to be enabled to use extensions. The supervisor will exit with error if theextensionsconfig key is present but the feature-gate is not used.extensionswas added to the supervisor configuration.config.Load()method. This better separates responsibility between theLoad()andValidate()functions. Previouslyconfig.Validate()was being called twice (once when loading the config from file and again when specifically callingValidate()inNewSupervisor()). Doing so also allows us to:extensionskey is present in the configLink to tracking issue
Partially closes: #47690
Testing
Documentation
Supervisor specification updated with usage for extensions.