receiver/gnmi: add gNMI receiver for network telemetry#47717
Open
sadhar wants to merge 1 commit intoopen-telemetry:mainfrom
Open
receiver/gnmi: add gNMI receiver for network telemetry#47717sadhar wants to merge 1 commit intoopen-telemetry:mainfrom
sadhar wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Soufiane Adhar <soufiane.adhar@gmail.com>
|
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
Comment on lines
+68
to
+69
| resAttrs.PutStr("device.address", target) | ||
| resAttrs.PutStr("host", target) |
Contributor
There was a problem hiding this comment.
Could we not use host.ip/name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a gNMI receiver. It supports streaming telemetry via Subscribe (Dial-in) and handles both typed and JSON-IETF values.
Note
This is the second part of my network telemetry contribution (following the yanggrpc receiver).